Bug 178619

Summary:

createImageBitmap with basic HTMLImageElement

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Canvas

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, dino, esprehn+autocc, graouts, gyuyoung.kim, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	graouts: review+

Description Dean Jackson 2017-10-21 00:35:26 PDT

createImageBitmap with basic HTMLImageElement

Comment 1 Dean Jackson 2017-10-21 00:36:24 PDT

<rdar://problem/35104118>

Comment 2 Dean Jackson 2017-10-21 00:41:05 PDT

Created attachment 324497 [details]
Patch

Comment 3 Antoine Quint 2017-10-21 01:03:46 PDT

Comment on attachment 324497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324497&action=review

> Source/WebCore/html/ImageBitmap.cpp:133
> +    // FIXME: Move this into a separate function and handle the cropping/resizing.

Could use a bugzilla bug here.

> LayoutTests/http/wpt/common/canvas-tests.js:35
> +function _assertPixel(canvas, x,y, r,g,b,a, pos, colour)

I'm pretty sure it's "color"

Comment 4 Dean Jackson 2017-10-21 14:49:28 PDT

Committed r223819: <https://trac.webkit.org/changeset/223819>