Bug 178617

Summary:

Web Inspector: Remove unused Console.setMonitoringXHREnabled

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, cdumez, commit-queue, esprehn+autocc, fpizlo, inspector-bugzilla-changes, jlewis3, joepeck, keith_miller, kondapallykalyan, mark.lam, msaboff, saam, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none
Fix Windows	none

Joseph Pecoraro

Reported 2017-10-20 23:31:34 PDT

Remove unused Console.setMonitoringXHREnabled * This hasn't ever been used by our frontend. * It shouldn't exist on Console. It is a Web concept. * It can be done in other ways and isn't needed here.

Attachments
[PATCH] Proposed Fix (15.38 KB, patch) 2017-10-20 23:42 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (17.29 KB, patch) 2017-10-20 23:57 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (26.70 KB, patch) 2017-10-21 00:07 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (26.71 KB, patch) 2017-10-21 00:10 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Fix Windows (35.21 KB, patch) 2017-10-23 09:54 PDT, Blaze Burg	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-10-20 23:41:42 PDT

*** Bug 155688 has been marked as a duplicate of this bug. ***

Joseph Pecoraro

Comment 2 2017-10-20 23:42:39 PDT

Created attachment 324491 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 3 2017-10-20 23:57:30 PDT

Created attachment 324493 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 4 2017-10-21 00:02:07 PDT

Comment on attachment 324493 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=324493&action=review > Source/JavaScriptCore/inspector/agents/JSGlobalObjectConsoleAgent.h:37 > JSGlobalObjectConsoleAgent(AgentContext&, InspectorHeapAgent*); > virtual ~JSGlobalObjectConsoleAgent() { } Actually I don't think this needs to be virtual anymore! Let me do a little more cleanup.

Joseph Pecoraro

Comment 5 2017-10-21 00:07:39 PDT

Created attachment 324494 [details] [PATCH] Proposed Fix Get to remove more and more and more!

Joseph Pecoraro

Comment 6 2017-10-21 00:10:24 PDT

Created attachment 324495 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 7 2017-10-21 15:23:05 PDT

Comment on attachment 324495 [details] [PATCH] Proposed Fix Clearing flags on attachment: 324495 Committed r223820: <https://trac.webkit.org/changeset/223820>

WebKit Commit Bot

Comment 8 2017-10-21 15:23:06 PDT

All reviewed patches have been landed. Closing bug.

Matt Lewis

Comment 9 2017-10-23 09:30:35 PDT

This caused a build break on Windows: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5427 https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5427/steps/compile-webkit/logs/stdio

Matt Lewis

Comment 10 2017-10-23 09:45:03 PDT

Reverted r223820 for reason: This caused a build break on Windows. Committed r223836: <https://trac.webkit.org/changeset/223836>

Blaze Burg

Comment 11 2017-10-23 09:54:40 PDT

Created attachment 324562 [details] Fix Windows

Blaze Burg

Comment 12 2017-10-23 17:55:57 PDT

Committed r223868: <https://trac.webkit.org/changeset/223868>

Radar WebKit Bug Importer

Comment 13 2017-11-15 12:58:13 PST

<rdar://problem/35568507>

Note You need to log in before you can comment on or make changes to this bug.