| Summary: | Do not run binding tests on multiple EWSes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, buildbot, commit-queue, dbates, glenn, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=169307 https://bugs.webkit.org/show_bug.cgi?id=111358 |
||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2017-10-20 12:50:27 PDT
This is also inefficient to run tests unnecessarily(and ignoring their result). This adds running time to multiple EWSes (which run tests) with no benefit. Created attachment 324433 [details]
Proposed patch
This fails webkitpy tests. I need to update them. That's why we need https://bugs.webkit.org/show_bug.cgi?id=178480 Created attachment 324445 [details]
Patch with updated unit-tests
Comment on attachment 324445 [details] Patch with updated unit-tests Clearing flags on attachment: 324445 Committed r223796: <https://trac.webkit.org/changeset/223796> All reviewed patches have been landed. Closing bug. (In reply to WebKit Commit Bot from comment #5) > Comment on attachment 324445 [details] > Patch with updated unit-tests > > Clearing flags on attachment: 324445 > > Committed r223796: <https://trac.webkit.org/changeset/223796> This change means that "webkit-patch build-and-test" and "webkit-patch build-and-test-attachment" no longer run the bindings tests. These commands exist as a convenience to build a patch and run all the test suites we have. I do not see the need to remove such convenience especially given that we have so many test suites. Is this actually how people use webkit-patch? |