Bug 178599

Summary: Do not run binding tests on multiple EWSes
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Severity: Normal CC: aakash_jain, ap, buildbot, commit-queue, dbates, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=169307
Description Flags
Proposed patch
ap: review+, aakash_jain: commit-queue-
Patch with updated unit-tests none

Description Aakash Jain 2017-10-20 12:50:27 PDT
We now have a separate bindings test EWS which run bindings-tests on every patch (as appropriate).

Currently all the EWSes which run tests also run bindings tests, but ignore it's output. There is no point in running these tests and ignoring the output. We should remove this old code.
Comment 1 Aakash Jain 2017-10-20 12:54:34 PDT
This is also inefficient to run tests unnecessarily(and ignoring their result). This adds running time to multiple EWSes (which run tests) with no benefit.
Comment 2 Aakash Jain 2017-10-20 12:54:44 PDT
Created attachment 324433 [details]
Proposed patch
Comment 3 Aakash Jain 2017-10-20 13:22:04 PDT
This fails webkitpy tests. I need to update them.

That's why we need https://bugs.webkit.org/show_bug.cgi?id=178480
Comment 4 Aakash Jain 2017-10-20 14:22:01 PDT
Created attachment 324445 [details]
Patch with updated unit-tests
Comment 5 WebKit Commit Bot 2017-10-20 14:56:54 PDT
Comment on attachment 324445 [details]
Patch with updated unit-tests

Clearing flags on attachment: 324445

Committed r223796: <https://trac.webkit.org/changeset/223796>
Comment 6 WebKit Commit Bot 2017-10-20 14:56:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Daniel Bates 2017-10-20 20:26:59 PDT
(In reply to WebKit Commit Bot from comment #5)
> Comment on attachment 324445 [details]
> Patch with updated unit-tests
> Clearing flags on attachment: 324445
> Committed r223796: <https://trac.webkit.org/changeset/223796>

This change means that "webkit-patch build-and-test" and "webkit-patch build-and-test-attachment" no longer run the bindings tests. These commands exist as a convenience to build a patch and run all the test suites we have. I do not see the need to remove such convenience especially given that we have so many test suites.
Comment 8 Alexey Proskuryakov 2017-10-22 13:08:36 PDT
Is this actually how people use webkit-patch?
Comment 9 Radar WebKit Bug Importer 2017-11-15 12:59:51 PST