Bug 178599

Summary: Do not run binding tests on multiple EWSes
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, buildbot, commit-queue, dbates, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=169307
https://bugs.webkit.org/show_bug.cgi?id=111358
Attachments:
Description Flags
Proposed patch
ap: review+, aakash_jain: commit-queue-
Patch with updated unit-tests none

Aakash Jain
Reported 2017-10-20 12:50:27 PDT
We now have a separate bindings test EWS which run bindings-tests on every patch (as appropriate). Currently all the EWSes which run tests also run bindings tests, but ignore it's output. There is no point in running these tests and ignoring the output. We should remove this old code.
Attachments
Proposed patch (1.72 KB, patch)
2017-10-20 12:54 PDT, Aakash Jain 		ap: review+
aakash_jain: commit-queue-
DetailsFormatted DiffDiff
Patch with updated unit-tests (7.97 KB, patch)
2017-10-20 14:22 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-10-20 12:54:34 PDT
This is also inefficient to run tests unnecessarily(and ignoring their result). This adds running time to multiple EWSes (which run tests) with no benefit.
Aakash Jain
Comment 2 2017-10-20 12:54:44 PDT
Created attachment 324433 [details] Proposed patch
Aakash Jain
Comment 3 2017-10-20 13:22:04 PDT
This fails webkitpy tests. I need to update them. That's why we need https://bugs.webkit.org/show_bug.cgi?id=178480
Aakash Jain
Comment 4 2017-10-20 14:22:01 PDT
Created attachment 324445 [details] Patch with updated unit-tests
WebKit Commit Bot
Comment 5 2017-10-20 14:56:54 PDT
Comment on attachment 324445 [details] Patch with updated unit-tests Clearing flags on attachment: 324445 Committed r223796: <https://trac.webkit.org/changeset/223796>
WebKit Commit Bot
Comment 6 2017-10-20 14:56:56 PDT
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 7 2017-10-20 20:26:59 PDT
(In reply to WebKit Commit Bot from comment #5) > Comment on attachment 324445 [details] > Patch with updated unit-tests > > Clearing flags on attachment: 324445 > > Committed r223796: <https://trac.webkit.org/changeset/223796> This change means that "webkit-patch build-and-test" and "webkit-patch build-and-test-attachment" no longer run the bindings tests. These commands exist as a convenience to build a patch and run all the test suites we have. I do not see the need to remove such convenience especially given that we have so many test suites.
Alexey Proskuryakov
Comment 8 2017-10-22 13:08:36 PDT
Is this actually how people use webkit-patch?
Radar WebKit Bug Importer
Comment 9 2017-11-15 12:59:51 PST
<rdar://problem/35568567>
Note You need to log in before you can comment on or make changes to this bug.