Summary: | ResourceResponse should have a ServiceWorker source | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, buildbot, cdumez, commit-queue, dbates, japhet, joepeck, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2017-10-20 10:46:59 PDT
Created attachment 324419 [details]
Patch
Comment on attachment 324419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324419&action=review > Source/WebCore/inspector/InspectorNetworkAgent.cpp:279 > + // FIXME: Add an Inspector ServiceWorker source. > + case ResourceResponse::Source::ServiceWorker: > + return Inspector::Protocol::Network::Response::Source::Unknown; Please file a bugzilla bug and assign it to me. FIXME's like this getting added to Inspector code are easy to get lost if there isn't a real bug with engineers CC'd to know about it! Created attachment 324423 [details]
Patch for landing
Comment on attachment 324423 [details] Patch for landing Clearing flags on attachment: 324423 Committed r223785: <https://trac.webkit.org/changeset/223785> All reviewed patches have been landed. Closing bug. |