Bug 178593

Summary: ResourceResponse should have a ServiceWorker source
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, cdumez, commit-queue, dbates, japhet, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2017-10-20 10:46:59 PDT
This will be useful for testing and for inspector.
Attachments
Patch (12.78 KB, patch)
2017-10-20 11:13 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.83 KB, patch)
2017-10-20 11:54 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-10-20 11:13:54 PDT
Created attachment 324419 [details] Patch
Joseph Pecoraro
Comment 2 2017-10-20 11:20:34 PDT
Comment on attachment 324419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324419&action=review > Source/WebCore/inspector/InspectorNetworkAgent.cpp:279 > + // FIXME: Add an Inspector ServiceWorker source. > + case ResourceResponse::Source::ServiceWorker: > + return Inspector::Protocol::Network::Response::Source::Unknown; Please file a bugzilla bug and assign it to me. FIXME's like this getting added to Inspector code are easy to get lost if there isn't a real bug with engineers CC'd to know about it!
youenn fablet
Comment 3 2017-10-20 11:54:13 PDT
Created attachment 324423 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-10-20 12:42:23 PDT
Comment on attachment 324423 [details] Patch for landing Clearing flags on attachment: 324423 Committed r223785: <https://trac.webkit.org/changeset/223785>
WebKit Commit Bot
Comment 5 2017-10-20 12:42:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-15 13:05:52 PST
<rdar://problem/35568778>
Note You need to log in before you can comment on or make changes to this bug.