Summary: | Support ::before/::after pseudo elements with display:contents | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, emilio, rniwa, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 157477 | ||||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2017-10-20 07:41:27 PDT
Created attachment 324398 [details]
patch
Comment on attachment 324398 [details] patch Attachment 324398 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4933455 New failing tests: svg/custom/assert-empty-layout-attributes.svg svg/text/svg-rtl-text-crash.html svg/custom/crash-textPath-attributes.html Created attachment 324403 [details]
Archive of layout-test-results from ews100 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 324398 [details] patch Attachment 324398 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4933517 New failing tests: svg/custom/assert-empty-layout-attributes.svg svg/text/svg-rtl-text-crash.html svg/custom/crash-textPath-attributes.html Created attachment 324405 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 324398 [details] patch Attachment 324398 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4933658 New failing tests: svg/custom/assert-empty-layout-attributes.svg svg/text/svg-rtl-text-crash.html svg/custom/crash-textPath-attributes.html Created attachment 324408 [details]
Archive of layout-test-results from ews115 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 324426 [details]
patch
Comment on attachment 324426 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=324426&action=review > Source/WebCore/style/RenderTreeUpdaterGeneratedContent.cpp:117 > + removeAndDestroyContentRenderers(*pseudoElement); > + Could you clarify why this code change is needed in the change log? > Source/WebCore/style/RenderTreeUpdaterGeneratedContent.cpp:156 > + if (pseudoElementRenderer) > + renderTreePosition.moveToLastChild(); > + else > + renderTreePosition.computeNextSibling(*pseudoElement); Could you also describe why code to move to the next sibling is needed in the change log? Added this: (WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement): In the normal case create a render tree position for the pseudo element renderer and use RenderTreePosition::moveToLastChild to make it a valid position. (The existing RenderTreePosition interface didn't have way to move to positions in anonymous boxes) In the case of a non box generating display:contents pseudo element, use the current render tree position instead. Ensure that pseudo element renderers are destroyed before creating the new ones since in display:contents case they are not descendants of the pseudo renderer and don't get cleared automatically. Created attachment 324496 [details]
patch
Comment on attachment 324496 [details] patch Clearing flags on attachment: 324496 Committed r223810: <https://trac.webkit.org/changeset/223810> All reviewed patches have been landed. Closing bug. |