Bug 178579

Summary: [GTK][WPE] generate-forwarding-headers.pl should also scan derived sources in WebKit framework
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: REOPENED    
Severity: Normal CC: annulen, cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 179055    
Bug Blocks: 178574    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2017-10-20 05:39:21 PDT
[GTK][WPE] generate-forwarding-headers.pl should also scan derived WK2 sources
Attachments
Patch (3.00 KB, patch)
2017-10-20 06:55 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-10-20 06:55:37 PDT
Created attachment 324392 [details] Patch
Carlos Garcia Campos
Comment 2 2017-10-23 23:53:09 PDT
Comment on attachment 324392 [details] Patch Thanks! I guess you have tried this with both clean and incremental builds.
Zan Dobersek
Comment 3 2017-10-24 01:17:16 PDT
(In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 324392 [details] > Patch > > Thanks! I guess you have tried this with both clean and incremental builds. Yes.
Zan Dobersek
Comment 4 2017-10-24 01:20:05 PDT
Comment on attachment 324392 [details] Patch Clearing flags on attachment: 324392 Committed r223884: <https://trac.webkit.org/changeset/223884>
Zan Dobersek
Comment 5 2017-10-24 01:20:09 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6 2017-10-31 07:42:27 PDT
Re-opened since this is blocked by bug 179055
Konstantin Tokarev
Comment 7 2017-10-31 07:47:07 PDT
Why is it needed? Isn't writing generated files to the correct place sufficient? Generating header for generated header sounds redundant.
Note You need to log in before you can comment on or make changes to this bug.