Bug 178562

Summary: [FrameView::layout cleanup] Scheduling layout should be disabled for FrameView::layout
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2017-10-19 20:22:09 PDT
and not just for a subset of the layout.
a scheduled layout would indicated a dirty tree (which is incorrect as we are supposed to leave ::layout with a clean tree)
Comment 1 Radar WebKit Bug Importer 2017-10-19 20:22:42 PDT
<rdar://problem/35089015>
Comment 2 zalan 2017-10-19 20:38:44 PDT
Created attachment 324342 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-10-19 22:24:49 PDT
Comment on attachment 324342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324342&action=review

> Source/WebCore/ChangeLog:9
> +        A scheduled layout at the end of FrameView::layout would indicated dirty tree (which is against FrameView::layout's contract).

would indicate a dirty tree (which is against the FrameView::layout's contract).

You seem to have just lengthened the scope of changeSchedulingEnabled by outdenting code; is this comment just saying that it's OK for the scope to last to the end of the function?
Comment 4 zalan 2017-10-19 22:35:41 PDT
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 324342 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324342&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        A scheduled layout at the end of FrameView::layout would indicated dirty tree (which is against FrameView::layout's contract).
> 
> would indicate a dirty tree (which is against the FrameView::layout's
> contract).
> 
> You seem to have just lengthened the scope of changeSchedulingEnabled by
> outdenting code; is this comment just saying that it's OK for the scope to
> last to the end of the function?
Correct.
Comment 5 zalan 2017-10-20 08:30:02 PDT
Created attachment 324402 [details]
Patch
Comment 6 WebKit Commit Bot 2017-10-20 13:40:27 PDT
Comment on attachment 324402 [details]
Patch

Clearing flags on attachment: 324402

Committed r223792: <https://trac.webkit.org/changeset/223792>
Comment 7 WebKit Commit Bot 2017-10-20 13:40:29 PDT
All reviewed patches have been landed.  Closing bug.