Bug 178561

Summary: Move common bindings files to unified sources
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, esprehn+autocc, jlewis3, kangil.han, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Keith Miller
Reported 2017-10-19 20:18:50 PDT
Move common bindings files to unified sources
Attachments
Patch (562.82 KB, patch)
2017-10-19 20:21 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (582.60 KB, patch)
2017-10-19 22:13 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (582.43 KB, patch)
2017-10-19 22:17 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (582.65 KB, patch)
2017-10-19 22:23 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (582.65 KB, patch)
2017-10-19 22:28 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (583.18 KB, patch)
2017-10-19 23:31 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (583.19 KB, patch)
2017-10-19 23:33 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (584.97 KB, patch)
2017-10-19 23:41 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-10-19 20:21:08 PDT
Created attachment 324338 [details] Patch
Keith Miller
Comment 2 2017-10-19 22:13:03 PDT
Created attachment 324352 [details] Patch
Keith Miller
Comment 3 2017-10-19 22:17:40 PDT
Created attachment 324353 [details] Patch
Keith Miller
Comment 4 2017-10-19 22:23:45 PDT
Created attachment 324354 [details] Patch
Keith Miller
Comment 5 2017-10-19 22:28:50 PDT
Created attachment 324356 [details] Patch
Ryosuke Niwa
Comment 6 2017-10-19 22:33:10 PDT
Comment on attachment 324356 [details] Patch rs=me
Keith Miller
Comment 7 2017-10-19 23:31:47 PDT
Created attachment 324360 [details] Patch
Keith Miller
Comment 8 2017-10-19 23:33:57 PDT
Created attachment 324361 [details] Patch
Keith Miller
Comment 9 2017-10-19 23:41:54 PDT
Created attachment 324363 [details] Patch
WebKit Commit Bot
Comment 10 2017-10-20 00:50:33 PDT
Comment on attachment 324363 [details] Patch Clearing flags on attachment: 324363 Committed r223747: <https://trac.webkit.org/changeset/223747>
WebKit Commit Bot
Comment 11 2017-10-20 00:50:35 PDT
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 12 2017-10-20 12:26:42 PDT
This revision cause a build break in windows: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5397 https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/5397/steps/compile-webkit/logs/stdio error: CMake Error at Source/cmake/WebKitMacros.cmake:128 (add_library): Cannot find source file: C:/cygwin/home/buildbot/slave/win-release/build/WebKitBuild/Release/DerivedSources/WebCore/UserAgentScriptsData.cpp
Radar WebKit Bug Importer
Comment 13 2017-11-15 13:01:20 PST
<rdar://problem/35568620>
Note You need to log in before you can comment on or make changes to this bug.