Bug 178552

Summary: ServiceWorkerContextManager should be an IPC::MessageReceiver
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, ggaren, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 178534    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-10-19 16:42:25 PDT
ServiceWorkerContextManager should be an IPC::MessageReceiver, to avoid putting too many ServiceWorker related methods on WebProcess class.
Attachments
Patch (24.22 KB, patch)
2017-10-19 16:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.79 KB, patch)
2017-10-19 16:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.53 KB, patch)
2017-10-19 18:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-10-19 16:45:48 PDT
Created attachment 324315 [details] Patch
Chris Dumez
Comment 2 2017-10-19 16:46:46 PDT
Created attachment 324316 [details] Patch
youenn fablet
Comment 3 2017-10-19 17:14:22 PDT
Comment on attachment 324316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324316&action=review > Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.messages.in:27 > + StartFetchInServiceWorker(uint64_t serverConnectionIdentifier, uint64_t fetchIdentifier, uint64_t serviceWorkerIdentifier, WebCore::ResourceRequest request, struct WebCore::FetchOptions options) Can we rename these to StartWorker and Fetch since they are now scoped by ServiceWorkerContextManager? > Source/WebKit/WebProcess/WebProcess.cpp:665 > #if ENABLE(SERVICE_WORKER) probably > Source/WebKit/WebProcess/WebProcess.cpp:667 > + if (m_serviceWorkerManager) Can you add ASSERT(m_serviceWorkerManager);
Chris Dumez
Comment 4 2017-10-19 18:38:17 PDT
Created attachment 324327 [details] Patch
Chris Dumez
Comment 5 2017-10-19 19:40:03 PDT
Comment on attachment 324327 [details] Patch Clearing flags on attachment: 324327 Committed r223739: <https://trac.webkit.org/changeset/223739>
Chris Dumez
Comment 6 2017-10-19 19:40:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 13:00:42 PST
<rdar://problem/35568595>
Note You need to log in before you can comment on or make changes to this bug.