ServiceWorkerContextManager should be an IPC::MessageReceiver

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

ServiceWorkerContextManager should be an IPC::MessageReceiver, to avoid putting too many ServiceWorker related methods on WebProcess class.

[Chris Dumez]

Created attachment 324315 [details]
Patch

[Chris Dumez]

Created attachment 324316 [details]
Patch

[youenn fablet]

Comment on attachment 324316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324316&action=review

> Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.messages.in:27
> +    StartFetchInServiceWorker(uint64_t serverConnectionIdentifier, uint64_t fetchIdentifier, uint64_t serviceWorkerIdentifier, WebCore::ResourceRequest request, struct WebCore::FetchOptions options)

Can we rename these to StartWorker and Fetch since they are now scoped by ServiceWorkerContextManager?

> Source/WebKit/WebProcess/WebProcess.cpp:665
>  

#if ENABLE(SERVICE_WORKER) probably

> Source/WebKit/WebProcess/WebProcess.cpp:667
> +        if (m_serviceWorkerManager)

Can you add ASSERT(m_serviceWorkerManager);

[Chris Dumez]

Created attachment 324327 [details]
Patch

[Chris Dumez]

Comment on attachment 324327 [details]
Patch

Clearing flags on attachment: 324327

Committed r223739: <https://trac.webkit.org/changeset/223739>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568595>