Bug 178550

Summary: SerializedScriptValue passed to postMessage() cannot be null
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dbates, esprehn+autocc, ggaren, kangil.han, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2017-10-19 16:20:48 PDT
SerializedScriptValue passed to postMessage() cannot be null. Therefore, we should use Ref<> type, not RefPtr<>.
Comment 1 Chris Dumez 2017-10-19 16:21:49 PDT
Created attachment 324310 [details]
Patch
Comment 2 youenn fablet 2017-10-19 16:26:02 PDT
Comment on attachment 324310 [details]
Patch

Would be cool to move from unique_ptr to UniqueRef as well.
Comment 3 Chris Dumez 2017-10-19 16:35:27 PDT
(In reply to youenn fablet from comment #2)
> Comment on attachment 324310 [details]
> Patch
> 
> Would be cool to move from unique_ptr to UniqueRef as well.

Channels can be nullptr.
Comment 4 Chris Dumez 2017-10-19 18:34:07 PDT
Comment on attachment 324310 [details]
Patch

Clearing flags on attachment: 324310

Committed r223732: <https://trac.webkit.org/changeset/223732>
Comment 5 Chris Dumez 2017-10-19 18:34:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 13:01:06 PST
<rdar://problem/35568614>