Bug 178547

Summary: Modernize API::DownloadClient
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, berto, buildbot, cgarcia, gustavo, jlewis3, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alex Christensen 2017-10-19 15:25:49 PDT
Modernize API::DownloadClient
Comment 1 Alex Christensen 2017-10-19 15:31:38 PDT
Created attachment 324302 [details]
Patch
Comment 2 Alex Christensen 2017-10-19 15:46:40 PDT
Created attachment 324305 [details]
Patch
Comment 3 Build Bot 2017-10-19 15:49:58 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Andy Estes 2017-10-19 15:56:31 PDT
Comment on attachment 324305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324305&action=review

> Source/WebKit/UIProcess/API/APIDownloadClient.h:42
> +enum class AllowOverwrite { No, Yes };

Kinda weird to put this in the place where we're forward declaring things.
Comment 5 Alex Christensen 2017-10-19 16:43:05 PDT
Created attachment 324314 [details]
Patch
Comment 6 Alex Christensen 2017-10-19 17:09:54 PDT
http://trac.webkit.org/r223730
Comment 8 Alex Christensen 2017-10-20 16:12:22 PDT
http://trac.webkit.org/r223798
Comment 9 Radar WebKit Bug Importer 2017-11-15 13:03:38 PST
<rdar://problem/35568704>