Bug 178542

Summary:

Generated serializers do not properly handle optional interface attributes

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Andy Estes

Reported 2017-10-19 14:01:33 PDT

Generated serializers do not properly handle optional interface attributes

Attachments
Patch (2.39 KB, patch) 2017-10-19 14:26 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (10.35 KB, patch) 2017-10-20 10:05 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (10.29 KB, patch) 2017-10-20 11:43 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-10-19 14:26:25 PDT Comment hidden (obsolete)

Created attachment 324285 [details] Patch

Build Bot

Comment 2 2017-10-19 14:28:43 PDT Comment hidden (obsolete)

Attachment 324285 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2017-10-19 14:31:13 PDT Comment hidden (obsolete)

Comment on attachment 324285 [details] Patch Attachment 324285 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/4923813 New failing tests: (JS) JSTestSerialization.cpp

Andy Estes

Comment 4 2017-10-20 10:05:26 PDT

Created attachment 324412 [details] Patch

Sam Weinig

Comment 5 2017-10-20 10:22:16 PDT

Comment on attachment 324412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324412&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5260 > + push(@implContent, " ASSERT(!${name}Value.isUndefined());\n"); I don't think this is necessary.

Andy Estes

Comment 6 2017-10-20 11:43:37 PDT

Created attachment 324421 [details] Patch

WebKit Commit Bot

Comment 7 2017-10-20 12:21:55 PDT

Comment on attachment 324421 [details] Patch Clearing flags on attachment: 324421 Committed r223780: <https://trac.webkit.org/changeset/223780>

WebKit Commit Bot

Comment 8 2017-10-20 12:21:57 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 9 2017-11-15 13:03:38 PST

<rdar://problem/35568705>

Note You need to log in before you can comment on or make changes to this bug.