| Summary: | Generated serializers do not properly handle optional interface attributes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, sam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andy Estes
2017-10-19 14:01:33 PDT
Created attachment 324285 [details]
Patch
Attachment 324285 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 324285 [details] Patch Attachment 324285 [details] did not pass bindings-ews (mac): Output: http://webkit-queues.webkit.org/results/4923813 New failing tests: (JS) JSTestSerialization.cpp Created attachment 324412 [details]
Patch
Comment on attachment 324412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324412&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5260 > + push(@implContent, " ASSERT(!${name}Value.isUndefined());\n"); I don't think this is necessary. Created attachment 324421 [details]
Patch
Comment on attachment 324421 [details] Patch Clearing flags on attachment: 324421 Committed r223780: <https://trac.webkit.org/changeset/223780> All reviewed patches have been landed. Closing bug. |