Bug 178537

Summary: Avoid duplicate multisample resolve before WebGL compositing
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dino, graouts, jer.noble, jlewis3, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jer.noble: review+

Dean Jackson
Reported 2017-10-19 13:19:11 PDT
Avoid duplicate multisample resolve before WebGL compositing
Attachments
Patch (4.13 KB, patch)
2017-10-19 13:23 PDT, Dean Jackson 		jer.noble: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-19 13:21:36 PDT
<rdar://problem/35080724>
Dean Jackson
Comment 2 2017-10-19 13:23:03 PDT
Created attachment 324272 [details] Patch
Dean Jackson
Comment 3 2017-10-19 13:32:52 PDT
Committed r223707: <https://trac.webkit.org/changeset/223707>
Matt Lewis
Comment 4 2017-10-19 14:10:03 PDT
This broke the iOS builds: https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/878 https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/878/steps/compile-webkit/logs/stdio error: CompileC /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/WebCore.build/Debug-iphonesimulator/WebCore.build/Objects-normal/x86_64/GraphicsContext3DOpenGLCommon.o platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
Dean Jackson
Comment 5 2017-10-19 14:17:15 PDT
iOS build fix in r223711
Note You need to log in before you can comment on or make changes to this bug.