Bug 178537 - Avoid duplicate multisample resolve before WebGL compositing
Summary: Avoid duplicate multisample resolve before WebGL compositing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-19 13:19 PDT by Dean Jackson
Modified: 2017-10-19 14:17 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.13 KB, patch)
2017-10-19 13:23 PDT, Dean Jackson
jer.noble: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-10-19 13:19:11 PDT
Avoid duplicate multisample resolve before WebGL compositing
Comment 1 Radar WebKit Bug Importer 2017-10-19 13:21:36 PDT
<rdar://problem/35080724>
Comment 2 Dean Jackson 2017-10-19 13:23:03 PDT
Created attachment 324272 [details]
Patch
Comment 3 Dean Jackson 2017-10-19 13:32:52 PDT
Committed r223707: <https://trac.webkit.org/changeset/223707>
Comment 4 Matt Lewis 2017-10-19 14:10:03 PDT
This broke the iOS builds:

https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/878
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20%28Build%29/builds/878/steps/compile-webkit/logs/stdio

error:
CompileC /Volumes/Data/slave/ios-simulator-11-debug/build/WebKitBuild/WebCore.build/Debug-iphonesimulator/WebCore.build/Objects-normal/x86_64/GraphicsContext3DOpenGLCommon.o platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
Comment 5 Dean Jackson 2017-10-19 14:17:15 PDT
iOS build fix in r223711