Summary: | Test262: RegExp/property-escapes/generated/Emoji_Component.js fails with current RegExp Unicode Properties implementation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | buildbot, commit-queue, jfbastien, keith_miller, mark.lam, saam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Michael Saboff
2017-10-19 10:23:30 PDT
The issue is that the test262 test is expecting results based on Emoji 5.0 and JSC is built with the Emoji 6.0 data file. Created attachment 324301 [details]
Patch
Comment on attachment 324301 [details]
Patch
I'm not sure I get this: deleting entries made more tests pass? I assume you're right, so r=me.
Oh actually, test262 is wrong: TC39 now floats the Unicode version to "the latest Unicode version", so we can be at 6.0 and we're correct. So this is a bad test. (In reply to JF Bastien from comment #5) > Oh actually, test262 is wrong: TC39 now floats the Unicode version to "the > latest Unicode version", so we can be at 6.0 and we're correct. So this is a > bad test. The issue is that 6.0 is an unratified draft at this point. Comment on attachment 324301 [details] Patch Clearing flags on attachment: 324301 Committed r223724: <https://trac.webkit.org/changeset/223724> All reviewed patches have been landed. Closing bug. |