Summary: | [Settings] Move global settings into their own file | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, darin, dino, thorton, webkit-bug-importer | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Attachments: |
|
Description
Sam Weinig
2017-10-19 06:08:25 PDT
Created attachment 324222 [details]
Patch
Created attachment 324223 [details]
Patch
Created attachment 324228 [details]
Patch
Created attachment 324230 [details]
Patch
Comment on attachment 324230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324230&action=review > Source/WebCore/ChangeLog:10 > + like to discourage, as WebCore can operate in a process with mulitple clients, each of typo: multiple > Source/WebCore/html/HTMLMediaElement.cpp:6822 > + return DeprecatedGlobalSettings::networkInterfaceName(); Looks like iOS build is failing because this file is missing an include of DeprecatedGlobalSettings.h. > Source/WebCore/page/DeprecatedGlobalSettings.h:33 > +class DeprecatedGlobalSettings { I think it would be good to delete the constructor. Created attachment 324244 [details]
Patch
Created attachment 324246 [details]
Patch
Created attachment 324264 [details]
Patch
Created attachment 324286 [details]
Patch
Comment on attachment 324286 [details] Patch Clearing flags on attachment: 324286 Committed r223720: <https://trac.webkit.org/changeset/223720> All reviewed patches have been landed. Closing bug. |