Bug 178512

Summary:

[Settings] Move global settings into their own file

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin, dino, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Sam Weinig

Reported 2017-10-19 06:08:25 PDT

[Settings] Move global settings into their own file

Attachments
Patch (142.06 KB, patch) 2017-10-19 06:24 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (142.06 KB, patch) 2017-10-19 06:38 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (142.66 KB, patch) 2017-10-19 07:47 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (143.69 KB, patch) 2017-10-19 07:51 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (143.91 KB, patch) 2017-10-19 10:10 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (145.02 KB, patch) 2017-10-19 10:19 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (145.09 KB, patch) 2017-10-19 12:44 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (146.77 KB, patch) 2017-10-19 14:26 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-10-19 06:24:50 PDT Comment hidden (obsolete)

Created attachment 324222 [details] Patch

Sam Weinig

Comment 2 2017-10-19 06:38:55 PDT Comment hidden (obsolete)

Created attachment 324223 [details] Patch

Sam Weinig

Comment 3 2017-10-19 07:47:38 PDT Comment hidden (obsolete)

Created attachment 324228 [details] Patch

Sam Weinig

Comment 4 2017-10-19 07:51:19 PDT

Created attachment 324230 [details] Patch

Darin Adler

Comment 5 2017-10-19 09:20:34 PDT

Comment on attachment 324230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324230&action=review > Source/WebCore/ChangeLog:10 > + like to discourage, as WebCore can operate in a process with mulitple clients, each of typo: multiple > Source/WebCore/html/HTMLMediaElement.cpp:6822 > + return DeprecatedGlobalSettings::networkInterfaceName(); Looks like iOS build is failing because this file is missing an include of DeprecatedGlobalSettings.h. > Source/WebCore/page/DeprecatedGlobalSettings.h:33 > +class DeprecatedGlobalSettings { I think it would be good to delete the constructor.

Sam Weinig

Comment 6 2017-10-19 10:10:09 PDT

Created attachment 324244 [details] Patch

Sam Weinig

Comment 7 2017-10-19 10:19:30 PDT

Created attachment 324246 [details] Patch

Sam Weinig

Comment 8 2017-10-19 12:44:40 PDT

Created attachment 324264 [details] Patch

Sam Weinig

Comment 9 2017-10-19 14:26:36 PDT

Created attachment 324286 [details] Patch