Bug 178512

Summary: [Settings] Move global settings into their own file
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dino, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Sam Weinig 2017-10-19 06:08:25 PDT
[Settings] Move global settings into their own file
Comment 1 Sam Weinig 2017-10-19 06:24:50 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2017-10-19 06:38:55 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2017-10-19 07:47:38 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2017-10-19 07:51:19 PDT
Created attachment 324230 [details]
Patch
Comment 5 Darin Adler 2017-10-19 09:20:34 PDT
Comment on attachment 324230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324230&action=review

> Source/WebCore/ChangeLog:10
> +        like to discourage, as WebCore can operate in a process with mulitple clients, each of

typo: multiple

> Source/WebCore/html/HTMLMediaElement.cpp:6822
> +    return DeprecatedGlobalSettings::networkInterfaceName();

Looks like iOS build is failing because this file is missing an include of DeprecatedGlobalSettings.h.

> Source/WebCore/page/DeprecatedGlobalSettings.h:33
> +class DeprecatedGlobalSettings {

I think it would be good to delete the constructor.
Comment 6 Sam Weinig 2017-10-19 10:10:09 PDT
Created attachment 324244 [details]
Patch
Comment 7 Sam Weinig 2017-10-19 10:19:30 PDT
Created attachment 324246 [details]
Patch
Comment 8 Sam Weinig 2017-10-19 12:44:40 PDT
Created attachment 324264 [details]
Patch
Comment 9 Sam Weinig 2017-10-19 14:26:36 PDT
Created attachment 324286 [details]
Patch
Comment 10 WebKit Commit Bot 2017-10-19 16:03:01 PDT
Comment on attachment 324286 [details]
Patch

Clearing flags on attachment: 324286

Committed r223720: <https://trac.webkit.org/changeset/223720>
Comment 11 WebKit Commit Bot 2017-10-19 16:03:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2017-11-15 13:02:35 PST
<rdar://problem/35568669>