Summary: | [FrameView::layout cleanup] Replace m_nestedLayoutCount with isLayoutNested() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
zalan
2017-10-18 19:41:06 PDT
Created attachment 324205 [details]
Patch
Created attachment 324206 [details]
Patch
Comment on attachment 324206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324206&action=review > Source/WebCore/page/FrameView.h:811 > + enum class LayoutNestedState { Invalid, NotNested, Nested }; > + LayoutNestedState m_layoutNestedState { LayoutNestedState::Invalid }; Maybe NotInLayout instead if Invalid? Wonder if we could some some sort of LayoutContext struct that would contain stuff that only makes sense during layout. Created attachment 324233 [details]
Patch
(In reply to Antti Koivisto from comment #4) > Comment on attachment 324206 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324206&action=review > > > Source/WebCore/page/FrameView.h:811 > > + enum class LayoutNestedState { Invalid, NotNested, Nested }; > > + LayoutNestedState m_layoutNestedState { LayoutNestedState::Invalid }; > > Maybe NotInLayout instead if Invalid? > > Wonder if we could some some sort of LayoutContext struct that would contain > stuff that only makes sense during layout. I was thinking about that too! Once I am done with this remove/rearrange/refactor frameview::layout, I'll take another look and see what type of context we could come up with. Comment on attachment 324233 [details] Patch Clearing flags on attachment: 324233 Committed r223689: <https://trac.webkit.org/changeset/223689> All reviewed patches have been landed. Closing bug. |