Bug 178496

Summary:

[FrameView::layout cleanup] Group related pre-layout code to improve readability

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2017-10-18 18:25:14 PDT

asserts
member variable resets
etc.

Comment 1 Radar WebKit Bug Importer 2017-10-18 18:25:58 PDT

<rdar://problem/35065718>

Comment 2 zalan 2017-10-18 18:34:58 PDT

Created attachment 324193 [details]
Patch

Comment 3 Simon Fraser (smfr) 2017-10-18 18:44:31 PDT

Comment on attachment 324193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324193&action=review

> Source/WebCore/page/FrameView.cpp:1360
> +    // we shouldn't enter layout() while painting

Sentence case please.

> Source/WebCore/page/FrameView.cpp:1363
> +        LOG(Layout, "  in  is disallowed, bailing");

Please change the message to distinguish this from the case above. This should say "in painting is".

Comment 4 zalan 2017-10-18 18:55:44 PDT

Created attachment 324195 [details]
Patch

Comment 5 WebKit Commit Bot 2017-10-18 19:22:48 PDT

Comment on attachment 324195 [details]
Patch

Clearing flags on attachment: 324195

Committed r223649: <https://trac.webkit.org/changeset/223649>

Comment 6 WebKit Commit Bot 2017-10-18 19:22:50 PDT

All reviewed patches have been landed.  Closing bug.