Bug 178496

Summary: [FrameView::layout cleanup] Group related pre-layout code to improve readability
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2017-10-18 18:25:14 PDT
asserts member variable resets etc.
Attachments
Patch (5.36 KB, patch)
2017-10-18 18:34 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (5.72 KB, patch)
2017-10-18 18:55 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-18 18:25:58 PDT
<rdar://problem/35065718>
zalan
Comment 2 2017-10-18 18:34:58 PDT
Created attachment 324193 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-10-18 18:44:31 PDT
Comment on attachment 324193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324193&action=review > Source/WebCore/page/FrameView.cpp:1360 > + // we shouldn't enter layout() while painting Sentence case please. > Source/WebCore/page/FrameView.cpp:1363 > + LOG(Layout, " in is disallowed, bailing"); Please change the message to distinguish this from the case above. This should say "in painting is".
zalan
Comment 4 2017-10-18 18:55:44 PDT
Created attachment 324195 [details] Patch
WebKit Commit Bot
Comment 5 2017-10-18 19:22:48 PDT
Comment on attachment 324195 [details] Patch Clearing flags on attachment: 324195 Committed r223649: <https://trac.webkit.org/changeset/223649>
WebKit Commit Bot
Comment 6 2017-10-18 19:22:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.