Summary: | Web Inspector: Styles Redesign: Newly added invalid property isn't immediately shown as invalid | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Nikita Vasilyev
2017-10-18 15:22:30 PDT
Created attachment 324175 [details]
[Animated GIF] Bug
Created attachment 324620 [details]
Patch
Created attachment 324621 [details] [Animated GIF] With patch applied HTML page for manual testing: http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/invalid.html Comment on attachment 324620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324620&action=review r=me > Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:367 > + let index = insertAfterIndex + 1; Nit: propertyIndex > Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:371 > + const dontFireEvents = true; Nit: suppressEvents or suppressEventDispatch > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:-128 > - this._element.classList.add(...classNames); I'd keep this as-is, unless there is some reason not to. Comment on attachment 324620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324620&action=review >> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:-128 >> - this._element.classList.add(...classNames); > > I'd keep this as-is, unless there is some reason not to. It used to be: this.element.className = ""; ... this._element.classList.add(...classNames); I replaced it with this._element.className = classNames.join(" "); to make it more concise. Created attachment 324856 [details]
Patch
Comment on attachment 324856 [details] Patch Clearing flags on attachment: 324856 Committed r223970: <https://trac.webkit.org/changeset/223970> All reviewed patches have been landed. Closing bug. |