Bug 178486

Summary: TestController should clear all fetch caches when resetting its state
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description youenn fablet 2017-10-18 15:00:44 PDT
TestController should clear all fetch caches when resetting its state
Comment 1 youenn fablet 2017-10-18 15:01:59 PDT
Created attachment 324171 [details]
Patch
Comment 2 Chris Dumez 2017-10-18 15:26:16 PDT
Comment on attachment 324171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324171&action=review

> Tools/WebKitTestRunner/TestController.cpp:787
> +    clearDOMCache(emptyString.get());

Wouldn't it be nicer to use separate methods rather than a magic value?
clearDOMCacheForOrigin(origin);
clearDOMCache();
Comment 3 youenn fablet 2017-10-18 16:03:40 PDT
Created attachment 324179 [details]
Patch
Comment 4 youenn fablet 2017-10-18 16:22:52 PDT
Created attachment 324180 [details]
Patch
Comment 5 Chris Dumez 2017-10-18 16:33:40 PDT
Comment on attachment 324180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324180&action=review

> Tools/WebKitTestRunner/TestController.cpp:2338
> +void TestController::clearDOMCaches()

You kept the magic value handing is clearDOMCache(WKStringRef origin).
Comment 6 youenn fablet 2017-10-18 17:15:58 PDT
Created attachment 324183 [details]
Patch
Comment 7 WebKit Commit Bot 2017-10-18 19:14:58 PDT
Comment on attachment 324183 [details]
Patch

Clearing flags on attachment: 324183

Committed r223648: <https://trac.webkit.org/changeset/223648>
Comment 8 WebKit Commit Bot 2017-10-18 19:15:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-10-18 19:16:15 PDT
<rdar://problem/35066305>