| Summary: | TestController should clear all fetch caches when resetting its state | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2017-10-18 15:00:44 PDT
Created attachment 324171 [details]
Patch
Comment on attachment 324171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324171&action=review > Tools/WebKitTestRunner/TestController.cpp:787 > + clearDOMCache(emptyString.get()); Wouldn't it be nicer to use separate methods rather than a magic value? clearDOMCacheForOrigin(origin); clearDOMCache(); Created attachment 324179 [details]
Patch
Created attachment 324180 [details]
Patch
Comment on attachment 324180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324180&action=review > Tools/WebKitTestRunner/TestController.cpp:2338 > +void TestController::clearDOMCaches() You kept the magic value handing is clearDOMCache(WKStringRef origin). Created attachment 324183 [details]
Patch
Comment on attachment 324183 [details] Patch Clearing flags on attachment: 324183 Committed r223648: <https://trac.webkit.org/changeset/223648> All reviewed patches have been landed. Closing bug. |