Bug 178486

Summary: TestController should clear all fetch caches when resetting its state
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2017-10-18 15:00:44 PDT
TestController should clear all fetch caches when resetting its state
Attachments
Patch (1.44 KB, patch)
2017-10-18 15:01 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (2.57 KB, patch)
2017-10-18 16:03 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (2.62 KB, patch)
2017-10-18 16:22 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (7.70 KB, patch)
2017-10-18 17:15 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-10-18 15:01:59 PDT
Created attachment 324171 [details] Patch
Chris Dumez
Comment 2 2017-10-18 15:26:16 PDT
Comment on attachment 324171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324171&action=review > Tools/WebKitTestRunner/TestController.cpp:787 > + clearDOMCache(emptyString.get()); Wouldn't it be nicer to use separate methods rather than a magic value? clearDOMCacheForOrigin(origin); clearDOMCache();
youenn fablet
Comment 3 2017-10-18 16:03:40 PDT
Created attachment 324179 [details] Patch
youenn fablet
Comment 4 2017-10-18 16:22:52 PDT
Created attachment 324180 [details] Patch
Chris Dumez
Comment 5 2017-10-18 16:33:40 PDT
Comment on attachment 324180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324180&action=review > Tools/WebKitTestRunner/TestController.cpp:2338 > +void TestController::clearDOMCaches() You kept the magic value handing is clearDOMCache(WKStringRef origin).
youenn fablet
Comment 6 2017-10-18 17:15:58 PDT
Created attachment 324183 [details] Patch
WebKit Commit Bot
Comment 7 2017-10-18 19:14:58 PDT
Comment on attachment 324183 [details] Patch Clearing flags on attachment: 324183 Committed r223648: <https://trac.webkit.org/changeset/223648>
WebKit Commit Bot
Comment 8 2017-10-18 19:15:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-10-18 19:16:15 PDT
<rdar://problem/35066305>
Note You need to log in before you can comment on or make changes to this bug.