Bug 178462

Summary: [Settings] Miscellaneous cleanup of the settings generation scripts
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2017-10-18 08:49:10 PDT
[Settings] Miscellaneous cleanup of the settings generation scripts
Attachments
Patch (31.08 KB, patch)
2017-10-18 08:56 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (35.51 KB, patch)
2017-10-18 09:11 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-10-18 08:56:44 PDT
Created attachment 324119 [details] Patch
Sam Weinig
Comment 2 2017-10-18 09:11:03 PDT
Created attachment 324121 [details] Patch
Daniel Bates
Comment 3 2017-10-18 10:00:43 PDT
Comment on attachment 324121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324121&action=review > Source/WebCore/ChangeLog:9 > + - Make functions operating on the python Setting object member functions python => Python > Source/WebCore/Scripts/GenerateSettings/Settings.py:82 > + if self.setNeedsStyleRecalcInAllFrames: > + return True > + return False return self.setNeedsStyleRecalcInAllFrames > Source/WebCore/Scripts/GenerateSettings/Settings.py:87 > + if self.type == 'String': > + return False > + return True return self.type != 'String' > Source/WebCore/Scripts/GenerateSettings/Settings.py:90 > + for prefix in ["css", "xss", "ftp", "dom"]: " => ' > Source/WebCore/Scripts/GenerateSettings/Settings.py:92 > + return "set" + uppercaseFirstN(self.name, len(prefix)) Ditto. > Source/WebCore/Scripts/GenerateSettings/Settings.py:93 > + return "set" + uppercaseFirstN(self.name, 1) Ditto.
WebKit Commit Bot
Comment 4 2017-10-18 10:10:21 PDT
Comment on attachment 324121 [details] Patch Clearing flags on attachment: 324121 Committed r223612: <https://trac.webkit.org/changeset/223612>
WebKit Commit Bot
Comment 5 2017-10-18 10:10:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-10-18 10:11:27 PDT
<rdar://problem/35053975>
Note You need to log in before you can comment on or make changes to this bug.