Bug 178462 – [Settings] Miscellaneous cleanup of the settings generation scripts

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[Settings] Miscellaneous cleanup of the settings generation scripts

[Sam Weinig]

Created attachment 324119 [details]
Patch

[Sam Weinig]

Created attachment 324121 [details]
Patch

[Daniel Bates]

Comment on attachment 324121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324121&action=review

> Source/WebCore/ChangeLog:9
> +        - Make functions operating on the python Setting object member functions

python => Python

> Source/WebCore/Scripts/GenerateSettings/Settings.py:82
> +        if self.setNeedsStyleRecalcInAllFrames:
> +            return True
> +        return False

return self.setNeedsStyleRecalcInAllFrames

> Source/WebCore/Scripts/GenerateSettings/Settings.py:87
> +        if self.type == 'String':
> +            return False
> +        return True

return self.type != 'String'

> Source/WebCore/Scripts/GenerateSettings/Settings.py:90
> +        for prefix in ["css", "xss", "ftp", "dom"]:

" => '

> Source/WebCore/Scripts/GenerateSettings/Settings.py:92
> +                return "set" + uppercaseFirstN(self.name, len(prefix))

Ditto.

> Source/WebCore/Scripts/GenerateSettings/Settings.py:93
> +        return "set" + uppercaseFirstN(self.name, 1)

Ditto.

[WebKit Commit Bot]

Comment on attachment 324121 [details]
Patch

Clearing flags on attachment: 324121

Committed r223612: <https://trac.webkit.org/changeset/223612>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35053975>