| Summary: | The compiler should always register a structure when it adds its transitionWatchPointSet. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Lam
2017-10-17 17:17:39 PDT
Created attachment 324074 [details]
proposed patch.
Comment on attachment 324074 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=324074&action=review r=me, but I suggest a name change. > Source/JavaScriptCore/dfg/DFGGraph.h:231 > + void registerAndWatchStructure(Structure*); Structures have multiple watchpoint sets, and we're adding new ones all the time. Saam's poly proto adds more. So, I would change this name to be more descriptive. Maybe: registerStructureAndWatchTransition. (In reply to Filip Pizlo from comment #2) > Comment on attachment 324074 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324074&action=review > > r=me, but I suggest a name change. > > > Source/JavaScriptCore/dfg/DFGGraph.h:231 > > + void registerAndWatchStructure(Structure*); > > Structures have multiple watchpoint sets, and we're adding new ones all the > time. Saam's poly proto adds more. > > So, I would change this name to be more descriptive. Maybe: > registerStructureAndWatchTransition. +1 for this name Created attachment 324125 [details]
patch for landing.
Thanks for the reviews. I've applied the requested rename. Will land shortly.
Landed in r223614: <http://trac.webkit.org/r223614>. |