Bug 178420

Summary: The compiler should always register a structure when it adds its transitionWatchPointSet.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
saam: review+
patch for landing. none

Mark Lam
Reported 2017-10-17 17:17:39 PDT
<rdar://problem/34814024>
Attachments
proposed patch. (18.22 KB, patch)
2017-10-17 17:33 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
patch for landing. (18.51 KB, patch)
2017-10-18 09:37 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-10-17 17:33:06 PDT
Created attachment 324074 [details] proposed patch.
Filip Pizlo
Comment 2 2017-10-17 17:36:29 PDT
Comment on attachment 324074 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=324074&action=review r=me, but I suggest a name change. > Source/JavaScriptCore/dfg/DFGGraph.h:231 > + void registerAndWatchStructure(Structure*); Structures have multiple watchpoint sets, and we're adding new ones all the time. Saam's poly proto adds more. So, I would change this name to be more descriptive. Maybe: registerStructureAndWatchTransition.
Saam Barati
Comment 3 2017-10-17 17:42:20 PDT
(In reply to Filip Pizlo from comment #2) > Comment on attachment 324074 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324074&action=review > > r=me, but I suggest a name change. > > > Source/JavaScriptCore/dfg/DFGGraph.h:231 > > + void registerAndWatchStructure(Structure*); > > Structures have multiple watchpoint sets, and we're adding new ones all the > time. Saam's poly proto adds more. > > So, I would change this name to be more descriptive. Maybe: > registerStructureAndWatchTransition. +1 for this name
Mark Lam
Comment 4 2017-10-18 09:37:07 PDT
Created attachment 324125 [details] patch for landing. Thanks for the reviews. I've applied the requested rename. Will land shortly.
Mark Lam
Comment 5 2017-10-18 10:42:44 PDT
Landed in r223614: <http://trac.webkit.org/r223614>.
Note You need to log in before you can comment on or make changes to this bug.