Bug 178419

Summary: [Settings] Replace macros in Settings.h/cpp with generated code
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, koivisto, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Sam Weinig 2017-10-17 17:14:07 PDT 
[Settings] Replace macros in Settings.h/cpp with generated code
Comment 1 Sam Weinig 2017-10-17 17:15:14 PDT 
Created attachment 324072 [details]
Patch
Comment 2 Sam Weinig 2017-10-17 20:04:30 PDT 
Created attachment 324091 [details]
Patch
Comment 3 Sam Weinig 2017-10-17 20:32:57 PDT 
Created attachment 324096 [details]
Patch
Comment 4 Antti Koivisto 2017-10-18 07:49:48 PDT 
Comment on attachment 324096 [details]
Patch

sounds good, r=me
Comment 5 WebKit Commit Bot 2017-10-18 08:16:38 PDT 
Comment on attachment 324096 [details]
Patch

Clearing flags on attachment: 324096

Committed r223607: <https://trac.webkit.org/changeset/223607>
Comment 6 WebKit Commit Bot 2017-10-18 08:16:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-18 08:18:10 PDT 
<rdar://problem/35051828>
Comment 8 Sam Sneddon [:gsnedders] 2022-07-02 05:49:55 PDT 
*** Bug 177681 has been marked as a duplicate of this bug. ***