Bug 178419

Summary: [Settings] Replace macros in Settings.h/cpp with generated code
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, koivisto, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2017-10-17 17:14:07 PDT
[Settings] Replace macros in Settings.h/cpp with generated code
Attachments
Patch (12.19 KB, patch)
2017-10-17 17:15 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (12.91 KB, patch)
2017-10-17 20:04 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (12.76 KB, patch)
2017-10-17 20:32 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-10-17 17:15:14 PDT
Created attachment 324072 [details] Patch
Sam Weinig
Comment 2 2017-10-17 20:04:30 PDT
Created attachment 324091 [details] Patch
Sam Weinig
Comment 3 2017-10-17 20:32:57 PDT
Created attachment 324096 [details] Patch
Antti Koivisto
Comment 4 2017-10-18 07:49:48 PDT
Comment on attachment 324096 [details] Patch sounds good, r=me
WebKit Commit Bot
Comment 5 2017-10-18 08:16:38 PDT
Comment on attachment 324096 [details] Patch Clearing flags on attachment: 324096 Committed r223607: <https://trac.webkit.org/changeset/223607>
WebKit Commit Bot
Comment 6 2017-10-18 08:16:40 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-10-18 08:18:10 PDT
<rdar://problem/35051828>
Sam Sneddon [:gsnedders]
Comment 8 2022-07-02 05:49:55 PDT
*** Bug 177681 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.