Bug 178419 - [Settings] Replace macros in Settings.h/cpp with generated code
Summary: [Settings] Replace macros in Settings.h/cpp with generated code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-17 17:14 PDT by Sam Weinig
Modified: 2017-10-18 08:18 PDT (History)
5 users (show)

See Also:


Attachments
Patch (12.19 KB, patch)
2017-10-17 17:15 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (12.91 KB, patch)
2017-10-17 20:04 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (12.76 KB, patch)
2017-10-17 20:32 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-10-17 17:14:07 PDT
[Settings] Replace macros in Settings.h/cpp with generated code
Comment 1 Sam Weinig 2017-10-17 17:15:14 PDT
Created attachment 324072 [details]
Patch
Comment 2 Sam Weinig 2017-10-17 20:04:30 PDT
Created attachment 324091 [details]
Patch
Comment 3 Sam Weinig 2017-10-17 20:32:57 PDT
Created attachment 324096 [details]
Patch
Comment 4 Antti Koivisto 2017-10-18 07:49:48 PDT
Comment on attachment 324096 [details]
Patch

sounds good, r=me
Comment 5 WebKit Commit Bot 2017-10-18 08:16:38 PDT
Comment on attachment 324096 [details]
Patch

Clearing flags on attachment: 324096

Committed r223607: <https://trac.webkit.org/changeset/223607>
Comment 6 WebKit Commit Bot 2017-10-18 08:16:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-18 08:18:10 PDT
<rdar://problem/35051828>