| Summary: | Expose _boundInterfaceIdentifier and _allowsCellularAccess to WKWebsiteDataStorePrivate | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, cgarcia, commit-queue, thorton, webkit-bug-importer | ||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Alex Christensen
2017-10-17 17:01:00 PDT
Created attachment 324077 [details]
Patch
Created attachment 324079 [details]
Patch
Created attachment 324083 [details]
Patch
Created attachment 324130 [details]
Patch
Created attachment 324132 [details]
Patch
Created attachment 324139 [details]
Patch
Comment on attachment 324139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324139&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:203 > - return _processPoolConfiguration->allowsCellularAccess(); > + return YES; The fact that there are no changes to the header to remove/deprecate/warn that these are lies is concerning. Created attachment 324145 [details]
Patch
Created attachment 324147 [details]
Patch
Created attachment 324149 [details]
Patch
Comment on attachment 324149 [details] Patch Attachment 324149 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4907596 New failing tests: http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl http/tests/cookies/third-party-cookie-relaxing.html imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/script-crossorigin-network.html http/tests/cookies/http-get-cookie-set-in-js.html http/tests/websocket/tests/hybi/httponly-cookie.pl http/tests/security/contentSecurityPolicy/report-and-enforce.php http/tests/security/svg-image-leak.html http/tests/cookies/private-cookie-storage.html http/tests/cookies/sync-xhr-set-cookie-invalidates-cache.html imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies.any.html imported/w3c/web-platform-tests/XMLHttpRequest/anonymous-mode-unsupported.htm http/tests/resourceLoadStatistics/remove-partitioning-from-redirect.html imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies.any.worker.html Created attachment 324166 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 324434 [details]
Patch
Comment on attachment 324434 [details] Patch Clearing flags on attachment: 324434 Committed r223791: <https://trac.webkit.org/changeset/223791> All reviewed patches have been landed. Closing bug. |