Bug 178417

Summary: Some older hardware can't actually use renderbuffers at the size they advertise
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, dino, graouts, kondapallykalyan, noam, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Dean Jackson
Reported 2017-10-17 16:56:55 PDT
This is failing, but only on older hardware (such as the test bots). Checking drawingBufferWidth/drawingBufferHeight PASS gl.drawingBufferWidth is gl.canvas.width PASS gl.drawingBufferHeight is gl.canvas.height PASS maxSize[0] > 0 is true PASS maxSize[1] > 0 is true MAX_VIEWPORT_DIMS = 16384x16384 canvas = 50x50 PASS gl.drawingBufferWidth > 0 is true PASS gl.drawingBufferHeight > 0 is true PASS gl.drawingBufferWidth <= maxSize[0] is true PASS gl.drawingBufferHeight <= maxSize[1] is true FAIL gl.getError() should be 0. Was 1286. Where 1286 is INVALID_FRAMEBUFFER_OPERATION I assume that trying to allocate such a huge backing store is sort-of working, but not really. I haven't been able to reproduce on newer hardware yet.
Attachments
Patch (3.68 KB, patch)
2017-10-18 15:39 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-17 16:57:55 PDT
<rdar://problem/35042291>
Dean Jackson
Comment 2 2017-10-18 15:34:01 PDT
Was "webgl/1.0.2/conformance/canvas/drawingbuffer-static-canvas-test.html failing"
Dean Jackson
Comment 3 2017-10-18 15:39:31 PDT
Created attachment 324176 [details] Patch
Dean Jackson
Comment 4 2017-10-18 16:42:26 PDT
Committed r223640: <https://trac.webkit.org/changeset/223640>
Note You need to log in before you can comment on or make changes to this bug.