Bug 178414 – [FrameView::layout cleanup] Remove redundant body->renderer()->setChildNeedsLayout call

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

it's not getting executed at all.

[Radar WebKit Bug Importer]

<rdar://problem/35040876>

[alan]

Created attachment 324067 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 324067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324067&action=review

> Source/WebCore/page/FrameView.cpp:-1444
> -                    if (!m_firstLayout && m_size.height() != layoutHeight() && body->renderer()->enclosingBox().stretchesToViewport())
> -                        body->renderer()->setChildNeedsLayout();

Does something else take care of the stretchesToViewport() case?

[alan]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 324067 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324067&action=review
> 
> > Source/WebCore/page/FrameView.cpp:-1444
> > -                    if (!m_firstLayout && m_size.height() != layoutHeight() && body->renderer()->enclosingBox().stretchesToViewport())
> > -                        body->renderer()->setChildNeedsLayout();
> 
> Does something else take care of the stretchesToViewport() case?

Yea, I tried to explain it in the Changelog entry.

[WebKit Commit Bot]

Comment on attachment 324067 [details]
Patch

Clearing flags on attachment: 324067

Committed r223590: <https://trac.webkit.org/changeset/223590>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.