Bug 178411

Summary: [iOS] Don't turn fields yellow after filling credentials
Product: WebKit Reporter: Chelsea Pugh <cpugh>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, cpugh, rmondello, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch for [iOS] Don't turn fields yellow after filling credentials none

Description Chelsea Pugh 2017-10-17 15:42:03 PDT
Don't turn fields yellow after filling credentials
Comment 1 Chelsea Pugh 2017-10-17 15:45:58 PDT
Created attachment 324066 [details]
Patch for [iOS] Don't turn fields yellow after filling credentials
Comment 2 Wenson Hsieh 2017-10-17 16:10:01 PDT
Comment on attachment 324066 [details]
Patch for [iOS] Don't turn fields yellow after filling credentials

rs=me.
Comment 3 Tim Horton 2017-10-17 16:13:00 PDT
Comment on attachment 324066 [details]
Patch for [iOS] Don't turn fields yellow after filling credentials

View in context: https://bugs.webkit.org/attachment.cgi?id=324066&action=review

> Source/WebCore/ChangeLog:5
> +

rdar://?

> Source/WebCore/editing/ios/AutofillElements.cpp:-124
> -        m_username->setAutoFilled();

Do we still need the underlying mechanism?
Comment 4 WebKit Commit Bot 2017-10-17 16:38:30 PDT
Comment on attachment 324066 [details]
Patch for [iOS] Don't turn fields yellow after filling credentials

Clearing flags on attachment: 324066

Committed r223585: <https://trac.webkit.org/changeset/223585>
Comment 5 WebKit Commit Bot 2017-10-17 16:38:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-17 16:38:55 PDT
<rdar://problem/35041874>