Bug 178394

Summary: [FrameView::layout cleanup] Move scrollbars setup logic to a separate function
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews117 for mac-elcapitan
none
Archive of layout-test-results from ews101 for mac-elcapitan
none
Patch none

alan
Reported 2017-10-17 09:49:57 PDT
from FrameView::layout
Attachments
Patch (5.70 KB, patch)
2017-10-17 09:57 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (5.62 KB, patch)
2017-10-17 11:01 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (5.57 KB, patch)
2017-10-17 11:53 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (5.58 KB, patch)
2017-10-17 12:39 PDT, alan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews117 for mac-elcapitan (1.84 MB, application/zip)
2017-10-17 13:47 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews101 for mac-elcapitan (1.06 MB, application/zip)
2017-10-17 13:50 PDT, Build Bot 		no flags
Details
Patch (5.52 KB, patch)
2017-10-19 12:25 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-17 09:50:25 PDT
<rdar://problem/35031066>
alan
Comment 2 2017-10-17 09:57:02 PDT
Created attachment 324020 [details] Patch
alan
Comment 3 2017-10-17 11:01:38 PDT
Created attachment 324030 [details] Patch
Simon Fraser (smfr)
Comment 4 2017-10-17 11:40:58 PDT
Comment on attachment 324030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324030&action=review > Source/WebCore/page/FrameView.cpp:1325 > +void FrameView::adjustScrollbarsForLayout(bool firstLayout, const RenderElement& layoutRoot) Weird to pass in layoutRoot just to have a way to get a Page&.
alan
Comment 5 2017-10-17 11:53:52 PDT
Created attachment 324037 [details] Patch
Antti Koivisto
Comment 6 2017-10-17 12:09:04 PDT
Comment on attachment 324037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324037&action=review > Source/WebCore/page/FrameView.cpp:1325 > +void FrameView::adjustScrollbarsForLayout(bool firstLayout) isFirstLayout would be more along WebKit style.
alan
Comment 7 2017-10-17 12:39:12 PDT
Created attachment 324041 [details] Patch
Build Bot
Comment 8 2017-10-17 13:47:40 PDT
Comment on attachment 324041 [details] Patch Attachment 324041 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4888125 New failing tests: http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html
Build Bot
Comment 9 2017-10-17 13:47:45 PDT
Created attachment 324050 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 10 2017-10-17 13:50:06 PDT
Comment on attachment 324041 [details] Patch Attachment 324041 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4888464 New failing tests: http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html
Build Bot
Comment 11 2017-10-17 13:50:07 PDT
Created attachment 324051 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
alan
Comment 12 2017-10-19 12:25:33 PDT
Created attachment 324263 [details] Patch
WebKit Commit Bot
Comment 13 2017-10-19 14:23:17 PDT
Comment on attachment 324263 [details] Patch Clearing flags on attachment: 324263 Committed r223712: <https://trac.webkit.org/changeset/223712>
WebKit Commit Bot
Comment 14 2017-10-19 14:23:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.