Bug 178394

Summary:

[FrameView::layout cleanup] Move scrollbars setup logic to a separate function

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Patch	none

Description zalan 2017-10-17 09:49:57 PDT

from FrameView::layout

Comment 1 Radar WebKit Bug Importer 2017-10-17 09:50:25 PDT

<rdar://problem/35031066>

Comment 2 zalan 2017-10-17 09:57:02 PDT

Created attachment 324020 [details]
Patch

Comment 3 zalan 2017-10-17 11:01:38 PDT

Created attachment 324030 [details]
Patch

Comment 4 Simon Fraser (smfr) 2017-10-17 11:40:58 PDT

Comment on attachment 324030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324030&action=review

> Source/WebCore/page/FrameView.cpp:1325
> +void FrameView::adjustScrollbarsForLayout(bool firstLayout, const RenderElement& layoutRoot)

Weird to pass in layoutRoot just to have a way to get a Page&.

Comment 5 zalan 2017-10-17 11:53:52 PDT

Created attachment 324037 [details]
Patch

Comment 6 Antti Koivisto 2017-10-17 12:09:04 PDT

Comment on attachment 324037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324037&action=review

> Source/WebCore/page/FrameView.cpp:1325
> +void FrameView::adjustScrollbarsForLayout(bool firstLayout)

isFirstLayout would be more along WebKit style.

Comment 7 zalan 2017-10-17 12:39:12 PDT

Created attachment 324041 [details]
Patch

Comment 8 Build Bot 2017-10-17 13:47:40 PDT

Comment on attachment 324041 [details]
Patch

Attachment 324041 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4888125

New failing tests:
http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html

Comment 9 Build Bot 2017-10-17 13:47:45 PDT

Created attachment 324050 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 10 Build Bot 2017-10-17 13:50:06 PDT

Comment on attachment 324041 [details]
Patch

Attachment 324041 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4888464

New failing tests:
http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html

Comment 11 Build Bot 2017-10-17 13:50:07 PDT

Created attachment 324051 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 12 zalan 2017-10-19 12:25:33 PDT

Created attachment 324263 [details]
Patch

Comment 13 WebKit Commit Bot 2017-10-19 14:23:17 PDT

Comment on attachment 324263 [details]
Patch

Clearing flags on attachment: 324263

Committed r223712: <https://trac.webkit.org/changeset/223712>

Comment 14 WebKit Commit Bot 2017-10-19 14:23:19 PDT

All reviewed patches have been landed.  Closing bug.