Bug 178374

Summary: ServiceWorkerRegistration should subclass RefCounted<>
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174541
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2017-10-16 20:41:24 PDT 
ServiceWorkerRegistration should subclass RefCounted<>.
Comment 1 Chris Dumez 2017-10-16 20:44:27 PDT 
Created attachment 323982 [details]
Patch
Comment 2 Ryosuke Niwa 2017-10-16 20:47:44 PDT 
Comment on attachment 323982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323982&action=review

> Source/WebCore/workers/service/ServiceWorkerRegistration.h:40
> -class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject {
> +class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject, public RefCounted<ServiceWorkerRegistration> {

We typically put RefCounted as the first class listed in the inheritance list.
Comment 3 Chris Dumez 2017-10-16 21:32:38 PDT 
Created attachment 323991 [details]
Patch
Comment 4 WebKit Commit Bot 2017-10-16 22:12:56 PDT 
Comment on attachment 323991 [details]
Patch

Clearing flags on attachment: 323991

Committed r223457: <https://trac.webkit.org/changeset/223457>
Comment 5 WebKit Commit Bot 2017-10-16 22:12:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-16 22:14:18 PDT 
<rdar://problem/35022851>