Summary: | ServiceWorkerRegistration should subclass RefCounted<> | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, rniwa, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=174541 | ||||||||
Attachments: |
|
Description
Chris Dumez
2017-10-16 20:41:24 PDT
Created attachment 323982 [details]
Patch
Comment on attachment 323982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323982&action=review > Source/WebCore/workers/service/ServiceWorkerRegistration.h:40 > -class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject { > +class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject, public RefCounted<ServiceWorkerRegistration> { We typically put RefCounted as the first class listed in the inheritance list. Created attachment 323991 [details]
Patch
Comment on attachment 323991 [details] Patch Clearing flags on attachment: 323991 Committed r223457: <https://trac.webkit.org/changeset/223457> All reviewed patches have been landed. Closing bug. |