Bug 178352

Summary: run-webkit-tests help text should mention arguments too
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, don.olmstead, glenn, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ross Kirsling
Reported 2017-10-16 11:37:04 PDT
run-webkit-tests help text should mention arguments too
Attachments
Patch (1.41 KB, patch)
2017-10-16 11:37 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (1.40 KB, patch)
2017-10-16 11:51 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2017-10-16 11:37:19 PDT
Created attachment 323915 [details] Patch
Ross Kirsling
Comment 2 2017-10-16 11:38:55 PDT
This is using the deprecated optparse instead of argparse, so apparently the only way to document arguments is by writing the Usage line manually. Still, this is an improvement for people just getting started with LayoutTests.
Tim Horton
Comment 3 2017-10-16 11:43:18 PDT
Comment on attachment 323915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323915&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:346 > + option_parser = optparse.OptionParser(usage="run_webkit_tests.py [options] [<path>...]") Technically run_webkit_tests.py should be %prog
Tim Horton
Comment 4 2017-10-16 11:44:31 PDT
Though oddly it shows the .py even though I'm running it as 'run-webkit-tests', so maybe this is already broken somehow.
Ross Kirsling
Comment 5 2017-10-16 11:51:40 PDT
Created attachment 323919 [details] Patch
WebKit Commit Bot
Comment 6 2017-10-16 13:27:23 PDT
Comment on attachment 323919 [details] Patch Clearing flags on attachment: 323919 Committed r223429: <https://trac.webkit.org/changeset/223429>
WebKit Commit Bot
Comment 7 2017-10-16 13:27:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-10-16 13:29:10 PDT
<rdar://problem/35013298>
Alexey Proskuryakov
Comment 9 2017-10-16 18:03:21 PDT
What is the observable effect of this change? There was a lot of documentation about arguments printed by run-webkit-tests —help already.
Tim Horton
Comment 10 2017-10-16 18:09:38 PDT
(In reply to Alexey Proskuryakov from comment #9) > What is the observable effect of this change? There was a lot of > documentation about arguments printed by run-webkit-tests —help already. This just changes the very first line, which previously didn’t mention the fact that you can pass test paths.
Note You need to log in before you can comment on or make changes to this bug.