Bug 178352

Summary: run-webkit-tests help text should mention arguments too
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, don.olmstead, glenn, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ross Kirsling 2017-10-16 11:37:04 PDT
run-webkit-tests help text should mention arguments too
Comment 1 Ross Kirsling 2017-10-16 11:37:19 PDT
Created attachment 323915 [details]
Patch
Comment 2 Ross Kirsling 2017-10-16 11:38:55 PDT
This is using the deprecated optparse instead of argparse, so apparently the only way to document arguments is by writing the Usage line manually.

Still, this is an improvement for people just getting started with LayoutTests.
Comment 3 Tim Horton 2017-10-16 11:43:18 PDT
Comment on attachment 323915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323915&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:346
> +    option_parser = optparse.OptionParser(usage="run_webkit_tests.py [options] [<path>...]")

Technically run_webkit_tests.py should be %prog
Comment 4 Tim Horton 2017-10-16 11:44:31 PDT
Though oddly it shows the .py even though I'm running it as 'run-webkit-tests', so maybe this is already broken somehow.
Comment 5 Ross Kirsling 2017-10-16 11:51:40 PDT
Created attachment 323919 [details]
Patch
Comment 6 WebKit Commit Bot 2017-10-16 13:27:23 PDT
Comment on attachment 323919 [details]
Patch

Clearing flags on attachment: 323919

Committed r223429: <https://trac.webkit.org/changeset/223429>
Comment 7 WebKit Commit Bot 2017-10-16 13:27:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-10-16 13:29:10 PDT
<rdar://problem/35013298>
Comment 9 Alexey Proskuryakov 2017-10-16 18:03:21 PDT
What is the observable effect of this change? There was a lot of documentation about arguments printed by run-webkit-tests —help already.
Comment 10 Tim Horton 2017-10-16 18:09:38 PDT
(In reply to Alexey Proskuryakov from comment #9)
> What is the observable effect of this change? There was a lot of
> documentation about arguments printed by run-webkit-tests —help already.

This just changes the very first line, which previously didn’t mention the fact that you can pass test paths.