Bug 178325

Summary: Web Inspector: scrolling the editor while debugging shouldn't trigger popovers
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199036
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2017-10-15 19:55:00 PDT
Summary: Scrolling the editor while debugging shouldn't trigger popovers. After one or more mousewheel events, a single mousemove event is fired. This causes the CodeMirrorTokenTrackingController to display a popover if a token comes to rest under the cursor. This can be *extremely* distracting when reading/scrolling code while the debugger is paused. It also causes a situation where popovers can appear while the mouse cursor is hidden. Steps to Reproduce: 1. Pause in the debugger 2. Cursor around in the editor using the arrow keys => The mouse cursor disappears 3. Scroll the editor using the trackpad/mouse wheel, a few lines at a time => Popover eventually appears once hidden cursor comes to rest over a token
Attachments
Patch (3.81 KB, patch)
2017-10-15 19:57 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-10-15 19:57:45 PDT
Created attachment 323863 [details] Patch
Radar WebKit Bug Importer
Comment 2 2017-10-15 19:58:57 PDT
<rdar://problem/35000636>
Devin Rousso
Comment 3 2017-10-20 21:40:03 PDT
Comment on attachment 323863 [details] Patch r=me. Nice! I've definitely run into this issue before :P
WebKit Commit Bot
Comment 4 2017-10-20 22:04:32 PDT
Comment on attachment 323863 [details] Patch Clearing flags on attachment: 323863 Committed r223807: <https://trac.webkit.org/changeset/223807>
WebKit Commit Bot
Comment 5 2017-10-20 22:04:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.