Bug 178324

Summary: Make some asserts into release asserts
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebCore Misc.Assignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, dbates, esprehn+autocc, fpizlo, kangil.han, keith_miller, mark.lam, msaboff, rniwa, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch sbarati: review+

Description Filip Pizlo 2017-10-15 19:34:51 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2017-10-15 19:36:23 PDT
Created attachment 323861 [details]
the patch
Comment 2 Radar WebKit Bug Importer 2017-10-15 19:36:47 PDT
<rdar://problem/35000510>
Comment 3 Filip Pizlo 2017-10-16 10:19:28 PDT
Landed in http://trac.webkit.org/changeset/223415/webkit
Comment 4 Ryosuke Niwa 2017-10-20 17:42:34 PDT
Comment on attachment 323861 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323861&action=review

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:88
> -    ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::isEventDispatchAllowedInSubtree(insertionPoint));
> +    RELEASE_ASSERT(NoEventDispatchAssertion::isEventDispatchAllowedInSubtree(insertionPoint));

This is useless because NoEventDispatchAssertion is not enabled in release builds.