Bug 178324

Summary: Make some asserts into release asserts
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebCore Misc.Assignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, dbates, esprehn+autocc, fpizlo, kangil.han, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2017-10-15 19:34:51 PDT
Patch forthcoming.
Attachments
the patch (16.42 KB, patch)
2017-10-15 19:36 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-10-15 19:36:23 PDT
Created attachment 323861 [details] the patch
Radar WebKit Bug Importer
Comment 2 2017-10-15 19:36:47 PDT
<rdar://problem/35000510>
Filip Pizlo
Comment 3 2017-10-16 10:19:28 PDT
Landed in http://trac.webkit.org/changeset/223415/webkit
Ryosuke Niwa
Comment 4 2017-10-20 17:42:34 PDT
Comment on attachment 323861 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=323861&action=review > Source/WebCore/dom/ContainerNodeAlgorithms.cpp:88 > - ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::isEventDispatchAllowedInSubtree(insertionPoint)); > + RELEASE_ASSERT(NoEventDispatchAssertion::isEventDispatchAllowedInSubtree(insertionPoint)); This is useless because NoEventDispatchAssertion is not enabled in release builds.
Note You need to log in before you can comment on or make changes to this bug.