Summary: | Web Inspector: Storage: values truncated in Local/Session table | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ricci Adams <webkit.org> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari 11 | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=198003 | ||||||||
Attachments: |
|
Description
Ricci Adams
2017-10-14 17:40:00 PDT
Does this reproduce in Safari Technology Preview? (In reply to Brian Burg from comment #1) > Does this reproduce in Safari Technology Preview? Yes. DOMStorageContentView.prototype._populate creates DataGridNodes with truncated values (length 200). Copy Row then copies the DataGridNode's data values, which is this truncated string. Likewise double click to edit gets the truncated value. Created attachment 366437 [details]
Patch
Comment on attachment 366437 [details]
Patch
I believe this was done for some performance reason (when very large values are stored in the table. Does this regress something?
(In reply to Joseph Pecoraro from comment #6) > Comment on attachment 366437 [details] > Patch > > I believe this was done for some performance reason (when very large values > are stored in the table. Does this regress something? Joe is right, that is why. Comment on attachment 366437 [details]
Patch
Clearing review until:
(1) we find a solution that solves both the performance and selection issue
(2) we make a decision that selection is more important than performance
This still affects my workflow all the time. Could the full value be re-fetched in response to a Copy command? (In reply to Ricci Adams from comment #9) > This still affects my workflow all the time. Could the full value be > re-fetched in response to a Copy command? That is a good idea! We should be able to override Copy in this table to get the full value and not the truncated string being displayed. Created attachment 367504 [details]
Patch
Comment on attachment 367504 [details]
Patch
r=me
Comment on attachment 367504 [details] Patch Clearing flags on attachment: 367504 Committed r244350: <https://trac.webkit.org/changeset/244350> All reviewed patches have been landed. Closing bug. |