Bug 178308

Summary: [JSC] modules can be visited more than once when resolving bindings through "star" exports as long as the exportName is different each time
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, darin, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2017-10-14 09:45:42 PDT
...
Attachments
Patch (9.51 KB, patch)
2017-10-15 21:52 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 2 2017-10-15 21:52:18 PDT
Created attachment 323872 [details] Patch
Yusuke Suzuki
Comment 3 2017-10-22 06:13:35 PDT
Ping?
Mark Lam
Comment 4 2017-10-24 09:57:45 PDT
Comment on attachment 323872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323872&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + With the change of the spec[1], we now do not need to remember star resoluted modules. I would say "resolved" instead of "resoluted".
Mark Lam
Comment 5 2017-10-24 09:59:15 PDT
(In reply to Mark Lam from comment #4) > > Source/JavaScriptCore/ChangeLog:8 > > + With the change of the spec[1], we now do not need to remember star resoluted modules. > > I would say "resolved" instead of "resoluted". Or "star resolution" also works.
Yusuke Suzuki
Comment 6 2017-10-24 10:11:36 PDT
Comment on attachment 323872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323872&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:8 >> + With the change of the spec[1], we now do not need to remember star resoluted modules. > > I would say "resolved" instead of "resoluted". star resolution sounds good. Fixed.
Yusuke Suzuki
Comment 7 2017-10-24 10:11:47 PDT
Committed r223894: <https://trac.webkit.org/changeset/223894>
Radar WebKit Bug Importer
Comment 8 2017-11-15 13:04:28 PST
<rdar://problem/35568734>
Note You need to log in before you can comment on or make changes to this bug.