Summary: | [JSC] modules can be visited more than once when resolving bindings through "star" exports as long as the exportName is different each time | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | buildbot, darin, keith_miller, mark.lam, msaboff, saam, sam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2017-10-14 09:45:42 PDT
Created attachment 323872 [details]
Patch
Ping? Comment on attachment 323872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323872&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + With the change of the spec[1], we now do not need to remember star resoluted modules. I would say "resolved" instead of "resoluted". (In reply to Mark Lam from comment #4) > > Source/JavaScriptCore/ChangeLog:8 > > + With the change of the spec[1], we now do not need to remember star resoluted modules. > > I would say "resolved" instead of "resoluted". Or "star resolution" also works. Comment on attachment 323872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323872&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:8 >> + With the change of the spec[1], we now do not need to remember star resoluted modules. > > I would say "resolved" instead of "resoluted". star resolution sounds good. Fixed. Committed r223894: <https://trac.webkit.org/changeset/223894> |