Bug 178306

Summary:

Use auto/nullptr in scrolling code

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

New Bugs

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cgarcia, cmarcelo, darin, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	cgarcia: review+, cgarcia: commit-queue-

Frédéric Wang (:fredw)

Reported 2017-10-14 08:12:32 PDT

Use auto/nullptr in scrolling code

Attachments
Patch (32.22 KB, patch) 2017-10-14 08:16 PDT, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
Patch (32.27 KB, patch) 2017-10-16 00:49 PDT, Frédéric Wang (:fredw)	cgarcia: review+ cgarcia: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2017-10-14 08:16:55 PDT

Created attachment 323809 [details] Patch

Frédéric Wang (:fredw)

Comment 2 2017-10-16 00:49:54 PDT

Created attachment 323878 [details] Patch Alternative version, with "auto*" used for pointers.

Carlos Garcia Campos

Comment 3 2017-10-16 00:52:59 PDT

Comment on attachment 323878 [details] Patch It seems this no longer applies

Frédéric Wang (:fredw)

Comment 4 2017-10-16 00:55:01 PDT

(In reply to Carlos Garcia Campos from comment #3) > Comment on attachment 323878 [details] > Patch > > It seems this no longer applies Yes, because of r223337. I'll update the patch.

Frédéric Wang (:fredw)

Comment 5 2017-10-16 00:58:22 PDT

Committed r223339: <https://trac.webkit.org/changeset/223339>

Radar WebKit Bug Importer

Comment 6 2017-10-16 00:59:08 PDT

<rdar://problem/35002866>

Note You need to log in before you can comment on or make changes to this bug.