| Summary: | Remove Editor::simplifyMarkup | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2017-10-13 11:07:12 PDT
Created attachment 323708 [details]
Patch
This was used in Mountain Lion, Mavericks, and Yosemite, but not since then. Comment on attachment 323708 [details] Patch I think it would be good to mention <rdar://problem/10726177>, and the fact that Mail stopped using this SPI long ago, in the ChangeLog. Comment on attachment 323708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323708&action=review > Source/WebKitLegacy/mac/WebView/WebView.mm:8535 > - (void)_simplifyMarkup:(DOMNode *)startNode endNode:(DOMNode *)endNode > { > - Frame* coreFrame = core([self mainFrame]); > - if (!coreFrame || !startNode) > - return; > - Node* coreStartNode= core(startNode); > - if (&coreStartNode->document() != coreFrame->document()) > - return; > - return coreFrame->editor().simplifyMarkup(coreStartNode, core(endNode)); > } What is the plan here? When will we remove the method too and not just its implementation? (In reply to Darin Adler from comment #6) > What is the plan here? When will we remove the method too and not just its > implementation? We reverted this change. Dan wants to keep using this method. |