Bug 178265

Summary: Allow modern decoding of URLs
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2017-10-13 10:13:57 PDT
Allow modern decoding of URLs
Attachments
Patch (2.43 KB, patch)
2017-10-13 10:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.85 KB, patch)
2017-10-16 12:52 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-10-13 10:14:22 PDT
Created attachment 323690 [details] Patch
Chris Dumez
Comment 2 2017-10-16 12:27:16 PDT
Comment on attachment 323690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323690&action=review r=me with suggestion. > Source/WebCore/platform/URL.h:299 > +std::optional<URL> URL::decode(Decoder& decoder) When you do this sort of things, could we rewrite the legacy decoder to use the modern one to avoid duplication? e.g. template <class Decoder> bool URL::decode(Decoder& decoder, URL& url) { auto optionalURL = URL::decode(decoder); if (!optionalURL) return false; url = optionalURL.value(); return true; }
Alex Christensen
Comment 3 2017-10-16 12:52:36 PDT
Created attachment 323929 [details] Patch
WebKit Commit Bot
Comment 4 2017-10-16 16:29:40 PDT
Comment on attachment 323929 [details] Patch Clearing flags on attachment: 323929 Committed r223446: <https://trac.webkit.org/changeset/223446>
WebKit Commit Bot
Comment 5 2017-10-16 16:29:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-10-16 16:30:05 PDT
<rdar://problem/35018342>
Note You need to log in before you can comment on or make changes to this bug.