Bug 178260

Summary: [css-grid] Avoid clearing the overrideContainingBlockWidth if possible
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jfernandez, rego, simon.fraser, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=178336
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Javier Fernandez
Reported 2017-10-13 07:04:24 PDT
We are clearing/update the overrideContainingBLockWidth in some cases that is not necessary; in some cases we do it due orthogonal flows logic needs. I think this unneeded clear/updates operations may lead to unexpected behaviors when computing intrinsic size, so we must avoid it when possible.
Attachments
Patch (10.59 KB, patch)
2017-10-13 07:19 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (10.60 KB, patch)
2017-10-16 03:19 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (10.61 KB, patch)
2017-10-25 09:03 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2017-10-13 07:19:33 PDT
Created attachment 323667 [details] Patch
Javier Fernandez
Comment 2 2017-10-16 03:19:37 PDT
Created attachment 323881 [details] Patch
Sergio Villar Senin
Comment 3 2017-10-25 08:47:09 PDT
Comment on attachment 323881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323881&action=review > Source/WebCore/ChangeLog:17 > + This changes is a defensive approach to avoid the issues caused by Nit: change
Javier Fernandez
Comment 4 2017-10-25 09:03:05 PDT
Created attachment 324829 [details] Patch
WebKit Commit Bot
Comment 5 2017-10-25 09:38:18 PDT
Comment on attachment 324829 [details] Patch Clearing flags on attachment: 324829 Committed r223955: <https://trac.webkit.org/changeset/223955>
WebKit Commit Bot
Comment 6 2017-10-25 09:38:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 13:05:45 PST
<rdar://problem/35568771>
Note You need to log in before you can comment on or make changes to this bug.