Bug 178247

Summary: Remove unnecessary include from Document.h
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: REOPENED    
Severity: Normal CC: ahmad.saleem792, buildbot, cdumez, darin, dbates, esprehn+autocc, kangil.han, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Alex Christensen
Reported 2017-10-12 18:14:19 PDT
Remove unnecessary include from Document.h
Attachments
Patch (2.87 KB, patch)
2017-10-12 18:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.89 KB, patch)
2017-10-12 18:52 PDT, Alex Christensen 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-10-12 18:14:45 PDT
Created attachment 323617 [details] Patch
Alex Christensen
Comment 2 2017-10-12 18:52:15 PDT
Created attachment 323620 [details] Patch
Darin Adler
Comment 3 2017-10-15 18:23:08 PDT
Comment on attachment 323620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323620&action=review > Source/WebCore/dom/Document.cpp:5548 > + return m_touchEventTargets ? m_touchEventTargets->size() : false; I think we should use && instead of ? : for this. > Source/WebCore/dom/Document.cpp:5557 > + return m_touchEventTargets ? m_touchEventTargets->contains(&node) : false; Ditto.
Alex Christensen
Comment 4 2017-10-16 12:49:35 PDT
http://trac.webkit.org/r223425
Radar WebKit Bug Importer
Comment 5 2017-10-16 12:50:02 PDT
<rdar://problem/35012315>
Ryan Haddad
Comment 6 2017-10-16 15:40:39 PDT
Reverted r223425 for reason: This change broke internal builds. Committed r223443: <https://trac.webkit.org/changeset/223443>
Ryan Haddad
Comment 7 2017-10-16 15:41:16 PDT
(In reply to Ryan Haddad from comment #6) > Reverted r223425 for reason: > > This change broke internal builds. > > Committed r223443: <https://trac.webkit.org/changeset/223443> See radar for details.
Ahmad Saleem
Comment 8 2022-10-05 16:00:47 PDT
This r+ patch got backed out but what it was trying to modify is still present: https://github.com/WebKit/WebKit/blob/b6c018250b04a3642c07f2bd1feb7ad3aaca312a/Source/WebCore/dom/Document.h#L1300 https://github.com/WebKit/WebKit/blob/b6c018250b04a3642c07f2bd1feb7ad3aaca312a/Source/WebCore/dom/Document.h#L66 Do we need this anymore? Appreciate if someone can mark this accordingly. Thanks!
Note You need to log in before you can comment on or make changes to this bug.