Bug 178244

Summary:

Web Inspector: Switch Clear navigation item back to the Trash icon (Console, Timelines, Network)

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, bburg, buildbot, commit-queue, inspector-bugzilla-changes, joepeck, jond, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[IMAGE] Before	none
[IMAGE] After	none

Description Joseph Pecoraro 2017-10-12 16:20:01 PDT

Switch Clear navigation item back to the Trash icon

While the Clear icon more closely matches system icons on macOS we have consistently received feedback that it is confusing / harder to understand. In most feedback users suggested a Trash icon, which is actually what we had before. I think we should revert to meet users expectations here.

If we can come up with a better icon in the future, I'm all for it!

Comment 1 Radar WebKit Bug Importer 2017-10-12 16:20:30 PDT

<rdar://problem/34966525>

Comment 2 Joseph Pecoraro 2017-10-12 16:21:47 PDT

Created attachment 323592 [details]
[PATCH] Proposed Fix

Comment 3 Joseph Pecoraro 2017-10-12 16:23:09 PDT

Created attachment 323593 [details]
[IMAGE] Before

Comment 4 Joseph Pecoraro 2017-10-12 16:23:22 PDT

Created attachment 323594 [details]
[IMAGE] After

Comment 5 BJ Burg 2017-10-12 17:28:25 PDT

Comment on attachment 323592 [details]
[PATCH] Proposed Fix

r=me

Comment 6 WebKit Commit Bot 2017-10-12 17:47:55 PDT

Comment on attachment 323592 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 323592

Committed r223268: <https://trac.webkit.org/changeset/223268>

Comment 7 WebKit Commit Bot 2017-10-12 17:47:56 PDT

All reviewed patches have been landed.  Closing bug.