Bug 178244 - Web Inspector: Switch Clear navigation item back to the Trash icon (Console, Timelines, Network)
Summary: Web Inspector: Switch Clear navigation item back to the Trash icon (Console, ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-12 16:20 PDT by Joseph Pecoraro
Modified: 2017-10-12 17:47 PDT (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (10.40 KB, patch)
2017-10-12 16:21 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[IMAGE] Before (59.66 KB, image/png)
2017-10-12 16:23 PDT, Joseph Pecoraro
no flags Details
[IMAGE] After (59.37 KB, image/png)
2017-10-12 16:23 PDT, Joseph Pecoraro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-10-12 16:20:01 PDT
Switch Clear navigation item back to the Trash icon

While the Clear icon more closely matches system icons on macOS we have consistently received feedback that it is confusing / harder to understand. In most feedback users suggested a Trash icon, which is actually what we had before. I think we should revert to meet users expectations here.

If we can come up with a better icon in the future, I'm all for it!
Comment 1 Radar WebKit Bug Importer 2017-10-12 16:20:30 PDT
<rdar://problem/34966525>
Comment 2 Joseph Pecoraro 2017-10-12 16:21:47 PDT
Created attachment 323592 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2017-10-12 16:23:09 PDT
Created attachment 323593 [details]
[IMAGE] Before
Comment 4 Joseph Pecoraro 2017-10-12 16:23:22 PDT
Created attachment 323594 [details]
[IMAGE] After
Comment 5 BJ Burg 2017-10-12 17:28:25 PDT
Comment on attachment 323592 [details]
[PATCH] Proposed Fix

r=me
Comment 6 WebKit Commit Bot 2017-10-12 17:47:55 PDT
Comment on attachment 323592 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 323592

Committed r223268: <https://trac.webkit.org/changeset/223268>
Comment 7 WebKit Commit Bot 2017-10-12 17:47:56 PDT
All reviewed patches have been landed.  Closing bug.