| Summary: | Mark more InlineBox member functions as const | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
| Component: | Layout and Rendering | Assignee: | Daniel Bates <dbates> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aestes, bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Bates
2017-10-12 10:13:16 PDT
Created attachment 323533 [details]
Patch
Comment on attachment 323533 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323533&action=review > Source/WebCore/rendering/InlineBox.cpp:295 > RenderBlockFlow& block = root().blockFlow(); We should add a const version of RootInlineBox::blockFlow() or have it always return a const RenderBlockFlow&. Will fix in a follow up bug/patch. Comment on attachment 323533 [details] Patch Clearing flags on attachment: 323533 Committed r223260: <https://trac.webkit.org/changeset/223260> All reviewed patches have been landed. Closing bug. (In reply to Daniel Bates from comment #2) > Comment on attachment 323533 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323533&action=review > > > Source/WebCore/rendering/InlineBox.cpp:295 > > RenderBlockFlow& block = root().blockFlow(); > > We should add a const version of RootInlineBox::blockFlow() or have it > always return a const RenderBlockFlow&. Will fix in a follow up bug/patch. Actually, we should think about whether this makes sense to do in the context of the render tree. Deferring for now. |