Bug 178217

Summary: Mark more InlineBox member functions as const
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Layout and RenderingAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2017-10-12 10:13:16 PDT
Mark more InlineBox member functions as const
Attachments
Patch (3.89 KB, patch)
2017-10-12 10:15 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-10-12 10:15:48 PDT
Created attachment 323533 [details] Patch
Daniel Bates
Comment 2 2017-10-12 14:36:53 PDT
Comment on attachment 323533 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323533&action=review > Source/WebCore/rendering/InlineBox.cpp:295 > RenderBlockFlow& block = root().blockFlow(); We should add a const version of RootInlineBox::blockFlow() or have it always return a const RenderBlockFlow&. Will fix in a follow up bug/patch.
Daniel Bates
Comment 3 2017-10-12 14:38:08 PDT
Comment on attachment 323533 [details] Patch Clearing flags on attachment: 323533 Committed r223260: <https://trac.webkit.org/changeset/223260>
Daniel Bates
Comment 4 2017-10-12 14:38:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-10-12 14:38:46 PDT
<rdar://problem/34964190>
Daniel Bates
Comment 6 2017-10-12 15:07:00 PDT
(In reply to Daniel Bates from comment #2) > Comment on attachment 323533 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323533&action=review > > > Source/WebCore/rendering/InlineBox.cpp:295 > > RenderBlockFlow& block = root().blockFlow(); > > We should add a const version of RootInlineBox::blockFlow() or have it > always return a const RenderBlockFlow&. Will fix in a follow up bug/patch. Actually, we should think about whether this makes sense to do in the context of the render tree. Deferring for now.
Note You need to log in before you can comment on or make changes to this bug.