Summary: | [iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | beidson, commit-queue, mitz, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=175034 | ||||||||||
Attachments: |
|
Description
Andy Estes
2017-10-11 12:12:53 PDT
Created attachment 323443 [details]
Patch
Created attachment 323492 [details]
Patch
Comment on attachment 323492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323492&action=review > Source/WebKit/Configurations/BaseTarget.xcconfig:120 > +WK_STORAGE_SERVICE_PRODUCT_NAME = com.apple.WebKit.Storage; > +WK_STORAGE_SERVICE_PRODUCT_NAME[sdk=iphoneos11*] = $(WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11$(IPHONEOS_DEPLOYMENT_TARGET:suffix:identifier)); > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_0 = com.apple.WebKit.Databases; > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_1 = com.apple.WebKit.Databases; > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_2 = com.apple.WebKit.Databases; > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_3 = com.apple.WebKit.Storage; > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_4 = com.apple.WebKit.Storage; > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_5 = com.apple.WebKit.Storage; > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_6 = com.apple.WebKit.Storage; > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_7 = com.apple.WebKit.Storage; > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_8 = com.apple.WebKit.Storage; > +WK_STORAGE_SERVICE_PRODUCT_NAME_IPHONEOS_11_9 = com.apple.WebKit.Storage; This can be written slightly more succinctly by enumerating just the exceptional cases. Something along the lines of (typed here without testing): WK_STORAGE_SERVICE_PRODUCT_NAME = $(WK_STORAGE_SERVICE_PRODUCT_NAME_$(WK_USE_LEGACY_STORAGE_SERVICE_NAME)); WK_STORAGE_SERVICE_PRODUCT_NAME_ = $(WK_STORAGE_SERVICE_PRODUCT_NAME_NO); WK_STORAGE_SERVICE_PRODUCT_NAME_NO = com.apple.WebKit.Storage; WK_STORAGE_SERVICE_PRODUCT_NAME_YES = com.apple.WebKit.Databases; WK_USE_LEGACY_STORAGE_SERVICE_NAME[sdk=iphoneos11*] = $(WK_USE_LEGACY_STORAGE_SERVICE_NAME_$(IPHONEOS_DEPLOYMENT_TARGET:suffix:identifier)); WK_USE_LEGACY_STORAGE_SERVICE_NAME_11_0 = YES; WK_USE_LEGACY_STORAGE_SERVICE_NAME_11_1 = YES; WK_USE_LEGACY_STORAGE_SERVICE_NAME_11_2 = YES; Created attachment 323534 [details]
Patch
Comment on attachment 323534 [details] Patch Clearing flags on attachment: 323534 Committed r223247: <https://trac.webkit.org/changeset/223247> All reviewed patches have been landed. Closing bug. Rolled out in r223559: <https://trac.webkit.org/changeset/223559> Committed r223719: <https://trac.webkit.org/changeset/223719> |