Summary: | Add a SW context process (where SW scripts will actually execute) | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, aestes, cdumez, commit-queue, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Brady Eidson
2017-10-10 22:05:59 PDT
Created attachment 323386 [details]
EWS run
Created attachment 323387 [details]
EWS run
Created attachment 323389 [details]
EWS run
Created attachment 323392 [details]
PFR
Comment on attachment 323392 [details] PFR View in context: https://bugs.webkit.org/attachment.cgi?id=323392&action=review > Source/WebCore/workers/service/server/SWServerRegistration.cpp:86 > + auto worker = m_server.createWorker(connection, m_registrationKey, m_currentJob->scriptURL, result.script, WorkerType::Classic); Surprised the compiler doesn't complain about worker not being used. > Source/WebCore/workers/service/server/SWServerRegistration.cpp:92 > + UNUSED_PARAM(workerID); You could also remove "workerID" from the function signature. > Source/WebCore/workers/service/server/SWServerRegistration.h:83 > + double m_lastUpdateTime { 0.0 }; No need for ".0" (In reply to Andy Estes from comment #5) > Comment on attachment 323392 [details] > PFR > > > Source/WebCore/workers/service/server/SWServerRegistration.cpp:92 > > + UNUSED_PARAM(workerID); > > You could also remove "workerID" from the function signature. Explicitly left it to make it super obvious what it is without having to hop to the header (will be used very soon) Created attachment 323423 [details]
Patch
Comment on attachment 323423 [details] Patch Clearing flags on attachment: 323423 Committed r223191: <https://trac.webkit.org/changeset/223191> All reviewed patches have been landed. Closing bug. |