Bug 178156 – Add a SW context process (where SW scripts will actually execute)

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Brady Eidson]

Add a SW context process (where SW scripts will actually execute)

[Brady Eidson]

Created attachment 323386 [details]
EWS run

[Brady Eidson]

Created attachment 323387 [details]
EWS run

[Brady Eidson]

Created attachment 323389 [details]
EWS run

[Brady Eidson]

Created attachment 323392 [details]
PFR

[Andy Estes]

Comment on attachment 323392 [details]
PFR

View in context: https://bugs.webkit.org/attachment.cgi?id=323392&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:86
> +    auto worker = m_server.createWorker(connection, m_registrationKey, m_currentJob->scriptURL, result.script, WorkerType::Classic);

Surprised the compiler doesn't complain about worker not being used.

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:92
> +    UNUSED_PARAM(workerID);

You could also remove "workerID" from the function signature.

> Source/WebCore/workers/service/server/SWServerRegistration.h:83
> +    double m_lastUpdateTime { 0.0 };

No need for ".0"

[Brady Eidson]

(In reply to Andy Estes from comment #5)
> Comment on attachment 323392 [details]
> PFR
> 
> > Source/WebCore/workers/service/server/SWServerRegistration.cpp:92
> > +    UNUSED_PARAM(workerID);
> 
> You could also remove "workerID" from the function signature.

Explicitly left it to make it super obvious what it is without having to hop to the header (will be used very soon)

[Brady Eidson]

Created attachment 323423 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 323423 [details]
Patch

Clearing flags on attachment: 323423

Committed r223191: <https://trac.webkit.org/changeset/223191>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34936051>