Bug 178153

Summary: Web Inspector: Open Resource Dialog should show path to resource (to disambiguate resources with same name)
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Xcode 9 UI
none
TOT Inspector UI
none
Patch
none
[Image] After Patch is applied none

Description BJ Burg 2017-10-10 19:33:16 PDT
Created attachment 323370 [details]
Xcode 9 UI

If a page has 20 index.js pages due to source maps, you can't tell which is which. We should show the folderized path below the main resource name.
Comment 1 BJ Burg 2017-10-10 19:33:47 PDT
Created attachment 323371 [details]
TOT Inspector UI
Comment 2 Radar WebKit Bug Importer 2017-10-10 19:34:27 PDT
<rdar://problem/34925686>
Comment 3 Devin Rousso 2018-10-03 22:50:00 PDT
Created attachment 351586 [details]
Patch

My attempt at using pure-ish CSS to get the desired effect.  The main issue is that since everything is `display: inline;`, it's hard to position things properly.
Comment 4 Devin Rousso 2018-10-03 22:50:26 PDT
Created attachment 351587 [details]
[Image] After Patch is applied
Comment 5 BJ Burg 2018-10-08 09:26:24 PDT
Comment on attachment 351586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351586&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:181
> +.open-resource-dialog .tree-outline.large .item .titles[data-path]::after {

Clever! I have never used Element.dataset.
Comment 6 WebKit Commit Bot 2018-10-08 10:15:28 PDT
Comment on attachment 351586 [details]
Patch

Clearing flags on attachment: 351586

Committed r236918: <https://trac.webkit.org/changeset/236918>
Comment 7 WebKit Commit Bot 2018-10-08 10:15:29 PDT
All reviewed patches have been landed.  Closing bug.