Summary: | [Payment Request] Validate that all PaymentCurrencyAmounts use the same currency code when using Apple Pay | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, beidson, buildbot, cdumez, commit-queue, dbates, esprehn+autocc, kondapallykalyan, ryanhaddad, sam, thorton, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 174796 | ||||||
Attachments: |
|
Description
Andy Estes
2017-10-10 17:55:25 PDT
Created attachment 323366 [details]
Patch
Comment on attachment 323366 [details] Patch Clearing flags on attachment: 323366 Committed r223163: <http://trac.webkit.org/changeset/223163> All reviewed patches have been landed. Closing bug. This change broke the Sierra build: (view as text) /Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:87:12: error: no viable conversion from returned value of type 'ApplePaySessionPaymentRequest::LineItem' to function return type 'ExceptionOr<ApplePaySessionPaymentRequest::LineItem>' /Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:100:12: error: no viable conversion from returned value of type 'Vector<ApplePaySessionPaymentRequest::LineItem>' to function return type 'ExceptionOr<Vector<ApplePaySessionPaymentRequest::LineItem> >' /Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:138:12: error: no viable conversion from returned value of type 'ApplePaySessionPaymentRequest::ShippingMethod' to function return type 'ExceptionOr<ApplePaySessionPaymentRequest::ShippingMethod>' https://build.webkit.org/builders/Apple%20Sierra%20Release%20%28Build%29/builds/5606 (In reply to Ryan Haddad from comment #5) > This change broke the Sierra build: > > (view as text) > /Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/ > paymentrequest/ApplePayPaymentHandler.cpp:87:12: error: no viable conversion > from returned value of type 'ApplePaySessionPaymentRequest::LineItem' to > function return type 'ExceptionOr<ApplePaySessionPaymentRequest::LineItem>' > /Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/ > paymentrequest/ApplePayPaymentHandler.cpp:100:12: error: no viable > conversion from returned value of type > 'Vector<ApplePaySessionPaymentRequest::LineItem>' to function return type > 'ExceptionOr<Vector<ApplePaySessionPaymentRequest::LineItem> >' > /Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/ > paymentrequest/ApplePayPaymentHandler.cpp:138:12: error: no viable > conversion from returned value of type > 'ApplePaySessionPaymentRequest::ShippingMethod' to function return type > 'ExceptionOr<ApplePaySessionPaymentRequest::ShippingMethod>' > > https://build.webkit.org/builders/Apple%20Sierra%20Release%20%28Build%29/ > builds/5606 Tried to fix in r223188: <https://trac.webkit.org/changeset/223188> |