Summary: | AccessibilityRenderObject should not hold a raw pointer to RenderObject | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | Accessibility | Assignee: | zalan <zalan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, koivisto, samuel_white, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
zalan
2017-10-10 14:14:16 PDT
Created attachment 323350 [details]
Patch
Comment on attachment 323350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323350&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.h:220 > + WeakPtr<RenderObject> m_renderer; can we move this to private, so fewer clients will be tempted to use it directly (In reply to chris fleizach from comment #3) > Comment on attachment 323350 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323350&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.h:220 > > + WeakPtr<RenderObject> m_renderer; > > can we move this to private, so fewer clients will be tempted to use it > directly Sure! Good idea. (In reply to zalan from comment #4) > (In reply to chris fleizach from comment #3) > > Comment on attachment 323350 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=323350&action=review > > > > > Source/WebCore/accessibility/AccessibilityRenderObject.h:220 > > > + WeakPtr<RenderObject> m_renderer; > > > > can we move this to private, so fewer clients will be tempted to use it > > directly > Sure! Good idea. If you don't mind, I'd rather do that in a separate patch. Comment on attachment 323350 [details] Patch Clearing flags on attachment: 323350 Committed r223151: <http://trac.webkit.org/changeset/223151> All reviewed patches have been landed. Closing bug. |