Bug 178144

Summary: AccessibilityRenderObject should not hold a raw pointer to RenderObject
Product: WebKit Reporter: zalan <zalan>
Component: AccessibilityAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, koivisto, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2017-10-10 14:14:16 PDT
the m_renderer's lifetime is not controlled by the AX object.
Comment 1 Radar WebKit Bug Importer 2017-10-10 14:14:32 PDT
<rdar://problem/34919287>
Comment 2 zalan 2017-10-10 14:25:51 PDT
Created attachment 323350 [details]
Patch
Comment 3 chris fleizach 2017-10-10 14:31:39 PDT
Comment on attachment 323350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323350&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.h:220
> +    WeakPtr<RenderObject> m_renderer;

can we move this to private, so fewer clients will be tempted to use it directly
Comment 4 zalan 2017-10-10 14:32:30 PDT
(In reply to chris fleizach from comment #3)
> Comment on attachment 323350 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323350&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.h:220
> > +    WeakPtr<RenderObject> m_renderer;
> 
> can we move this to private, so fewer clients will be tempted to use it
> directly
Sure! Good idea.
Comment 5 zalan 2017-10-10 15:09:28 PDT
(In reply to zalan from comment #4)
> (In reply to chris fleizach from comment #3)
> > Comment on attachment 323350 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=323350&action=review
> > 
> > > Source/WebCore/accessibility/AccessibilityRenderObject.h:220
> > > +    WeakPtr<RenderObject> m_renderer;
> > 
> > can we move this to private, so fewer clients will be tempted to use it
> > directly
> Sure! Good idea.
If you don't mind, I'd rather do that in a separate patch.
Comment 6 WebKit Commit Bot 2017-10-10 15:47:34 PDT
Comment on attachment 323350 [details]
Patch

Clearing flags on attachment: 323350

Committed r223151: <http://trac.webkit.org/changeset/223151>
Comment 7 WebKit Commit Bot 2017-10-10 15:47:35 PDT
All reviewed patches have been landed.  Closing bug.