Bug 178143

Summary:

Web Inspector: Avoid "100.00ms" vs "100.0ms" jitter in TimelineRuler labels

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	bburg: review+

Description Joseph Pecoraro 2017-10-10 13:49:12 PDT

Avoid "100.00ms" vs "100.0ms" jitter in TimelineRuler labels

Sometimes the ms calculated ends up being values like:

    100.0             => "100.0ms"
    100.0000000000001 => "100.00ms"

Account for this tiny jitter by checking against values like 100.0001.

Comment 1 Joseph Pecoraro 2017-10-10 13:50:39 PDT

Created attachment 323346 [details]
[PATCH] Proposed Fix

Comment 2 BJ Burg 2017-10-10 14:09:46 PDT

Comment on attachment 323346 [details]
[PATCH] Proposed Fix

r=me. Can you extract out the slop factor into a variable?

Comment 3 Joseph Pecoraro 2017-10-11 01:00:41 PDT

<https://trac.webkit.org/changeset/223171/webkit>

Comment 4 Radar WebKit Bug Importer 2017-10-11 01:01:47 PDT

<rdar://problem/34928802>